Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli tool to change containerd config #313

Conversation

mkulke
Copy link

@mkulke mkulke commented Jan 8, 2024

No description provided.

@mkulke mkulke changed the title Mkulke/containerd config cli tool cli tool to change containerd config Jan 8, 2024
@fidencio
Copy link
Member

@mkulke, one thing that's been crossing my mind is whether we need a new tool for this or whether we'd be good enough relying on tomlq for this as we did on the Kata Containers side.

I'd like to know your opinion on this,

@mkulke
Copy link
Author

mkulke commented Jan 11, 2024

@mkulke, one thing that's been crossing my mind is whether we need a new tool for this or whether we'd be good enough relying on tomlq for this as we did on the Kata Containers side.

I'd like to know your opinion on this,

as said above, it doesn't matter whether you use a library or a cli tool, but if you want to have some confidence in what is happening, i.e. write tests and handle all those potential errors properly, this is probably easier to do in a dedicated tool.

a simple tomlq invocation will just handle the happy path, the rest you have to code (or opt to ignore) in bash

@fidencio
Copy link
Member

a simple tomlq invocation will just handle the happy path, the rest you have to code (or opt to ignore) in bash

Fair enough! :-)

@fidencio
Copy link
Member

@mkulke, with the change of getting this daemonset from the nydus-snapshotter directly, I think suggesting such a change to their repo would be a better fit, no?

@mkulke
Copy link
Author

mkulke commented Jan 19, 2024

@mkulke, with the change of getting this daemonset from the nydus-snapshotter directly, I think suggesting such a change to their repo would be a better fit, no?

indeed, do you have a pointer for that nydus daemonset installer effort?

@mkulke mkulke closed this Jan 19, 2024
@fidencio
Copy link
Member

@mkulke: containerd/nydus-snapshotter#570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants