Skip to content

Commit

Permalink
Release: attempt to fix docker manifest commands
Browse files Browse the repository at this point in the history
This effectively reverts PR 366 and drops the guarding
quotes around extra_docker_manifest_flags that were added
to these commands in 351.
The CI is still throwing an error to the effect of:
"error parsing name for manifest list : invalid reference
format". This seems to stem from an empty string in
the command b/c of an empty extra_docker_manifest_flag
variable. Hence, we are reverting quotes that were added
around it in PR 351.

Signed-off-by: Chris Porter <[email protected]>
  • Loading branch information
portersrc committed Apr 30, 2024
1 parent db56787 commit 13285e0
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions install/pre-install-payload/payload.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,18 @@ function build_payload() {
purge_previous_manifests "${registry}:${tag}"
purge_previous_manifests "${registry}:latest"

docker manifest create "${extra_docker_manifest_flags}" \
docker manifest create ${extra_docker_manifest_flags} \
"${registry}:${tag}" \
"${registry}:x86_64-${tag}" \
"${registry}:s390x-${tag}"
--amend "${registry}:x86_64-${tag}" \
--amend "${registry}:s390x-${tag}"

docker manifest create "${extra_docker_manifest_flags}" \
docker manifest create ${extra_docker_manifest_flags} \
"${registry}:latest" \
"${registry}:x86_64-${tag}" \
"${registry}:s390x-${tag}"
--amend "${registry}:x86_64-${tag}" \
--amend "${registry}:s390x-${tag}"

docker manifest push "${extra_docker_manifest_flags}" "${registry}:${tag}"
docker manifest push "${extra_docker_manifest_flags}" "${registry}:latest"
docker manifest push ${extra_docker_manifest_flags} "${registry}:${tag}"
docker manifest push ${extra_docker_manifest_flags} "${registry}:latest"

popd
}
Expand Down

0 comments on commit 13285e0

Please sign in to comment.