Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop deprecated eaa_kbc + move gh actions to Ubuntu 24.04 #734

Merged
merged 3 commits into from
Oct 14, 2024
Merged

drop deprecated eaa_kbc + move gh actions to Ubuntu 24.04 #734

merged 3 commits into from
Oct 14, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Oct 2, 2024

No description provided.

@mythi mythi force-pushed the cleanup branch 2 times, most recently from 14add28 to 0beb76c Compare October 2, 2024 13:47
@mythi
Copy link
Contributor Author

mythi commented Oct 2, 2024

(I will wait and rebase to #731 before moving away from draft)

@mythi
Copy link
Contributor Author

mythi commented Oct 4, 2024

@mkulke added 3a97cb4 here

@mythi mythi marked this pull request as ready for review October 4, 2024 14:17
@mythi mythi requested a review from a team as a code owner October 4, 2024 14:17
Xynnn007
Xynnn007 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I do not know if kata's guest image uses ubuntu 24.04 now. If not, some potential problems like compatibility would not be found.

@mythi
Copy link
Contributor Author

mythi commented Oct 14, 2024

I do not know if kata's guest image uses ubuntu 24.04 now. If not, some potential problems like compatibility would not be found.

The alternative for this PR is to change ubuntu-latest to point back to ubuntu-22.04 but my preference is to jump to ubuntu-24.04. We would not be able to cover all distros for the guest image anyways. AFAICS peer-pods isn't using ubuntu at all.

mythi added 3 commits October 14, 2024 13:16
@mythi
aa: drop deprecated eaa_kbc
269e156 
CoCo quickstart has had a warning about EAA/verdict deprecation for more
than a year and over 2 CoCo releases.

Drop the unmaintained/deprecated code from the repo.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
gh: use Ubuntu 24.04 runners
84310b4 
ubuntu-latest now points to ubuntu-24.04 so we have a mix of Ubuntu
runners in use. Move everything to ubuntu-24.04 to pin to a specific
version.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
gh: update cc_kbc CI checks
610a970 
KBC has not been used in attestation-agent/Makefile in a while
so the build matrix runs the same loop five times.

The new parameter is "ATTESTER". Make all CI checks
(build/lint/unit test) to use that.

Signed-off-by: Mikko Ylinen <[email protected]>
fitzthum
fitzthum approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dcmiddle
dcmiddle approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@dcmiddle dcmiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
fwiw, I scanned for any missed references to the removed components and tests but didn't find anything.
There's an open PR in confidential-containers to remove instruction references to eaa kbc.
(The website might have some content cleanup to do).

@fitzthum fitzthum merged commit 25dbce5 into confidential-containers:main Oct 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xynnn007 Xynnn007 Xynnn007 approved these changes

@dcmiddle dcmiddle dcmiddle approved these changes

@fitzthum fitzthum fitzthum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mythi @fitzthum @dcmiddle @Xynnn007