Fix configuration file default value and make error information more detailed #726
Conversation
This default value of KBS cert would make the KBS client to read it as a PEM cert, thus always fails to launch. Without this default value, the `kbs_cert` field inside the KBS config will be a None, which means no cert reading and parsing will be performed. Signed-off-by: Xynnn007 <[email protected]>
This patch replaces all error info formating from `{e}` to `{e:?}`. In
rust, `{e:?}` would print a much more detailed information of an error
than `{e}`. This would help to gather more details when debugging.
Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-kbs-client
branch
from
7a844d1 to
e60028e
Compare
There was a problem hiding this comment.
thanks @Xynnn007 for looking into this so quickly, can we maybe also as a drive-by fix make a missing credentials setting in the CDH conf default to []?
at the moment users have to specify explicitly, even if a user does not use the feature.
credentials = []
The unit tests probably need updating to get this path covered? |
Without this section it could be fine. See the unit test for config example https://github.com/confidential-containers/guest-components/blob/main/confidential-data-hub/hub/src/config.rs#L249-L261
|
- Bump to pick up the CDH config fix from confidential-containers/guest-components#726 Signed-off-by: stevenhorsman <[email protected]>
- Bump to pick up the CDH config fix from confidential-containers/guest-components#726 Signed-off-by: stevenhorsman <[email protected]>
- Bump to pick up the CDH config fix from confidential-containers/guest-components#726 Signed-off-by: stevenhorsman <[email protected]>
Please see the commit message of this PR.
cc @stevenhorsman