GHA: Fix condition for duplicate checks post-merge #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite confidential-containers#644, duplicate checks are still being triggered post-merge. The following condition seemed intuitive: - github.event_name != 'push' || github.event.pull_request.merged == false But it turns out that `pull_request.merged` is still false on merge, which allows the job to proceed. (see https://github.com/BbolroC/cc-guest-components/actions/runs/10215060610/workflow) This commit focuses solely on `github.event_name != 'push'`, which is true on merge. (see https://github.com/BbolroC/cc-guest-components/actions/runs/10215137827/workflow) Signed-off-by: Hyounggyu Choi <[email protected]>
fitzthum
approved these changes
Aug 2, 2024
|
Let’s see if anyone opposes this after the intended CI behavior occurs. Thanks! (maybe someone who wants to push something directly to main?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite #644, duplicate checks are still being triggered post-merge. The following condition seemed intuitive:
But it turns out that
pull_request.mergedis still false on merge, which allows the job to proceed.(see https://github.com/BbolroC/cc-guest-components/actions/runs/10215060610/workflow)
This commit focuses solely on
github.event_name != 'push', which is true on merge.(see https://github.com/BbolroC/cc-guest-components/actions/runs/10215137827/workflow)
Signed-off-by: Hyounggyu Choi [email protected]