-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump tdx-attest-rs from DCAP_1.16 to DCAP_1.19 #380
Conversation
it is not safe for the underlying lib version |
What's the concern? AFAICS the crate has not had functional changes since 1.16 and the builds are already using "latest" due to #352 |
I have checked inside the code that the API does not change, while I get suggestions from Intel folks that it is recommended to use the same version of DCAP as the underlying It is awkward that current rootfs uses |
Ok. Let's not merge this right now if we are uncertain about it. |
should it move to v1.16 for the release to match what guest-component uses? v1.15 is almost 1 year old |
Bumps [tdx-attest-rs](https://github.com/intel/SGXDataCenterAttestationPrimitives) from DCAP_1.16 to DCAP_1.19. - [Release notes](https://github.com/intel/SGXDataCenterAttestationPrimitives/releases) - [Commits](intel/SGXDataCenterAttestationPrimitives@71557c7...8a40733) --- updated-dependencies: - dependency-name: tdx-attest-rs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
e904813
to
f08cbc9
Compare
Maybe now is the time? |
Could I assign this to you? |
I don't have the powers to merge. I think it needs to be made in two stages: 1) get this PR merged first, 2) update the rootfs packages at the same time a new version of this repo is pulled into the kata build |
I can help to get this merged
I know that people are busy doing merge-to-main things. I am not sure which branch and whether it is ok to do this now. Hi @fitzthum @stevenhorsman Could you share some contexts? |
So it order to get this merged and tested in kata-container's rootfs, we aren't in a good spot now:
I guess there are a couple of approaches we could take if this is urgent to merge into attestation-agent now:
I'm not sure if this helps - sorry if I'm missing background, or other suggestions. |
Superseded by #442. |
Bumps tdx-attest-rs from DCAP_1.16 to DCAP_1.19.
Release notes
Sourced from tdx-attest-rs's releases.
Commits
8a40733
Intel(R) SGX DCAP 1.19 Release6882afa
Intel(R) SGX DCAP 1.18 Releasee7604e0
fix(sgx-dcap-quoteverify-sys): successfull build with SGX_SDK unsetb1cdd25
build(deps): increase bindgen version0443ae2
Intel(R) SGX DCAP 1.17 Release4cb5c8b
Fix typo in comments71bc4f6
Fix typo in sgx_dcap_quoteverify.h7f84575
Update to correct URL for Azure local_pck_url (#307)1e969e0
QuoteGeneration/Makefile: Fix incorrect usage of exit3ea8e6b
Merge pull request #300 from fqiu1/add-qgs-get-platform-infoYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)