podvm_mkosi: Remove remaining references to builder #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove references to fedora-binaries-builder in the code and docs now we have a combined multistage dockerfile Signed-off-by: stevenhorsman <[email protected]>
mkulke
approved these changes
Dec 18, 2024
stevenhorsman
merged commit 7e98574
into
confidential-containers:main
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I didn't do the full job when merging the builder and binaries phase, so left some references to
fedora-binaries-builder in the code and docs (I was going to run both in parallel, but decided it
made more sense to switch and only did a partial job). This should fix the azure nightly build (and we still need to work
on integrating that with the other workflows I guess).