podvm_mkosi: multistage binaries #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been tested on x86 in my fork: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12256747305 |
mkulke
approved these changes
Dec 13, 2024
wainersm
reviewed
Dec 16, 2024
| -f ../podvm/Dockerfile.podvm_binaries.fedora ../../ | ||
| $(if $(filter $(PUSH),true),,-o type=local,dest="./resources/binaries-tree") \ | ||
| $(DOCKER_OPTS) \ | ||
| -f ../podvm/Dockerfile.podvm.fedora ../../ |
There was a problem hiding this comment.
Hi @stevenhorsman !
Shouldn't it still use Dockerfile.podvm_binaries.fedora?
There was a problem hiding this comment.
Sorry, I renamed this last minute (I created a new one in order to keep the old code untouched before deciding this didn't make sense). I will fix and re-test. thanks for the spot!
wainersm
reviewed
Dec 16, 2024
| FROM ${BUILDER_IMG} AS podvm_builder | ||
| ARG ARCH="amd64" | ||
| ARG YQ_ARCH="amd64" | ||
| # PROTOC_ARCH="x86_64" | "s390_64" |
stevenhorsman
force-pushed
the
multi-stage-podvm-dockerfile
branch
from
991ac00 to
d203390
Compare
wainersm
approved these changes
Dec 17, 2024
Simplify the podvm_mkosi binaries building process by combining the builder and binaries into a single multistage dockerfile Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
multi-stage-podvm-dockerfile
branch
from
d203390 to
1b86606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the podvm_mkosi binaries building process by combining the builder and binaries into a single multistage dockerfile