Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S390x runner testing #2203

Merged

Conversation

stevenhorsman
Copy link
Member

Revert the changes that skipped s390x testing so we can debug the runners now that @BbolroC is back to help us.
Unfortunately we can't test it on fork runners as in a fresh environment it all passed, so we specifically need to ensure that the runners shared with other CoCo projects are cleaned up to run our workfloads

This reverts commit abb6b3a.

Revert so we can re-test the s390x now that Choi is available to
help.

Signed-off-by: stevenhorsman <[email protected]>
This reverts commit 7963412.

Signed-off-by: stevenhorsman <[email protected]>
@stevenhorsman stevenhorsman requested a review from a team as a code owner December 11, 2024 10:19
Copy link
Member

@BbolroC BbolroC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's debug anything on the runner! Thanks @stevenhorsman !

@stevenhorsman stevenhorsman merged commit d2ad316 into confidential-containers:main Dec 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants