Kustomize: parameterize tunnel type #2192
Conversation
Some provisioners do not have a parameter for VXLAN port. This patch introduces a parameter for it in such providers. Signed-off-by: Yohei Ueda <[email protected]>
This patch introduces a parameter to specify the tunnel type for pod networking. If this parameter is not set, the default VXLAN is used. Signed-off-by: Yohei Ueda <[email protected]>
There was a problem hiding this comment.
I triggered the tests, let's see. code looks good to me.
I understand that this is also in preparation for a wireguard tunnel option. I like the small incremental PRs, that make it a lot easier to review 👍
Maybe what you want to do to keep track of the wireguard feature is to create a tracking issue "Introduce Wireguard as tunneling option" (or something like that). And in the issue you maintain a simple roadmap like this:
|
The crio test fails to pull the following image |
Yeah - that is failing in the nightly tests as well: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12192920460/job/34014702289. I assume that @wainersm is aware of it, but maybe that's not the case. Anyway it doesn't indicate an issue with this PR! |
Yeah, it's unrelated. And also the image doesn't exist.. |
So the image does exist, but it's private as its the image used for authenticated registry tests, so that's why you can't see it 😄 |
|
Merging this one.. |
This is a prerequisite of #688
This PR introduces a parameter to specify the tunnel type for pod networking. If this parameter is not set, the default VXLAN is used.
Some e2e test provisioners do not have a parameter for VXLAN port. This PR also introduces a parameter for it in such providers.