workflow: Actually temporarily skip the s390x e2e tests #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised too late that adding a `false` to a list of or's does nothing. I wanted to preserve the code, but we can just revert, so it was pointless. Sorry! Signed-off-by: stevenhorsman <[email protected]>
wainersm
reviewed
Dec 5, 2024
| @@ -266,12 +266,7 @@ jobs: | |||
| libvirt_s390x: | |||
| name: E2E tests on libvirt for the s390x architecture | |||
| # Skip s390x e2e tests until Choi is available to set-up the s390x runner's pre-action properly. Then revert this. | |||
| if: | | |||
There was a problem hiding this comment.
my bad, I reviewed and merged the previous PR without realizing that.
Here you want use 'false &&' to preserve the entire block. Whatever you prefer, I will ack regardless.
There was a problem hiding this comment.
Yeah, false && was what I should have done originally, but I'm not taking any chance this time!
wainersm
approved these changes
Dec 5, 2024
mkulke
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised too late that adding a
falseto a list of or's does nothing. I wanted to preserve the code, but we can just revert, so it was pointless. Sorry!