Skip to content

Commit

Permalink
WIP: Try unskipping the previously flakey libvirt tests to check them
Browse files Browse the repository at this point in the history
  • Loading branch information
stevenhorsman committed Dec 5, 2024
1 parent 303f631 commit d99d9c8
Showing 1 changed file with 1 addition and 21 deletions.
22 changes: 1 addition & 21 deletions src/cloud-api-adaptor/test/e2e/libvirt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ func TestLibvirtCreateSimplePod(t *testing.T) {
}

func TestLibvirtCreatePodWithConfigMap(t *testing.T) {
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePodWithConfigMap(t, testEnv, assert)
}
Expand Down Expand Up @@ -62,52 +61,35 @@ func TestLibvirtCreatePeerPodAndCheckUserLogs(t *testing.T) {
}

func TestLibvirtCreatePeerPodAndCheckWorkDirLogs(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckWorkDirLogs(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageAndDeployment(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithImageAndDeployment(t, testEnv, assert)
}

func TestLibvirtCreateNginxDeployment(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/2046
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestNginxDeployment(t, testEnv, assert)
}

/*
Failing due to issues will pulling image (ErrImagePull)
func TestLibvirtCreatePeerPodWithLargeImage(t *testing.T) {
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodWithLargeImage(t, testEnv, assert)
}
*/

func TestLibvirtDeletePod(t *testing.T) {
assert := LibvirtAssert{}
Expand All @@ -116,7 +98,6 @@ func TestLibvirtDeletePod(t *testing.T) {

func TestLibvirtPodToServiceCommunication(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
SkipTestOnCI(t)
if isTestOnCrio() {
t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)")
}
Expand All @@ -126,7 +107,6 @@ func TestLibvirtPodToServiceCommunication(t *testing.T) {

func TestLibvirtPodsMTLSCommunication(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
SkipTestOnCI(t)
if isTestOnCrio() {
t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)")
}
Expand Down

0 comments on commit d99d9c8

Please sign in to comment.