This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Fix blog statistics viewcount #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing include from bare.
Moved frontend_forms_form_elements_form_privacy into the submit form group.
... so we have the checkbox next to the text instead of above.
…or messages from the form-elements.tpl
…dden" - otherwise just the label is printed out.
…type is "hidden". Otherwise just the label is printed out.
Fixed order of supplier info & links like in bootstrap Bare default.
Update description.tpl
Fixed tabs links in custom parent pages to link to the link instead of the custom page URL, if a custom link is set. Furthermore added data-attributes and target like in menu links.
Added bootstrap document templates
Added document templates from bare to make documents work.
…-templates Add Bare document templates to bootstrap theme
{if {config name=showCompanySelectField}} vs {if {config name=showCompanySelectField} == 0}
…elect field, because many customers missed changing this field, so all of them where "male". Hint: In different to bare, we had to remove the disabled attribute from the newly added option, because the javascript which creates the stylable select box, ignores disabled items. Howewer, it works fine due to the empty value attribute.
…ill needs work "plugin is undefined")
… "plugin is undefined" - also in the shopware demo https://www.shopwaredemo.de)
….js to the latest responsive theme version
…onsent solution >> Removed console logs
…implementation in parameters.
… library modifications as possible. Remaining required library modifications are caused by SW mistakes and their missing development against interfaces / plugins. Hopefully this will be solved in SW core in the future.
Added condition like in Bare Theme for frontend_index_footer_last_articles
…ingpage-Condition Update index.tpl
blog_id parameter was missing so blog views were not counted
|
Hey @JPustkuchen, thank you for your PR and sorry for the big delay. and please target the dev branch, which will be merged into the 2.0 branch soon. |
|
Hi Uehler, sorry I know I made mistakes when creating the pull request, but mostly they contain combined changes from multiple issues because they were pushed into the same branch. I already invested several days of my personal time for these patches and currently I'm very busy so I don't think I'll have the time to split the merge requests in 2020. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.