-
Notifications
You must be signed in to change notification settings - Fork 21
Add (Bare) document templates #39
base: 2.0
Are you sure you want to change the base?
Add (Bare) document templates #39
Conversation
Added missing include from bare.
Moved frontend_forms_form_elements_form_privacy into the submit form group.
... so we have the checkbox next to the text instead of above.
…or messages from the form-elements.tpl
…dden" - otherwise just the label is printed out.
…type is "hidden". Otherwise just the label is printed out.
Fixed order of supplier info & links like in bootstrap Bare default.
Update description.tpl
Fixed tabs links in custom parent pages to link to the link instead of the custom page URL, if a custom link is set. Furthermore added data-attributes and target like in menu links.
Added bootstrap document templates
Added document templates from bare to make documents work.
Hey @JPustkuchen, thank you for your PR and sorry for the big delay. and please target the dev branch, which will be merged into the 2.0 branch soon. |
Same reason as written in my other comments. We made a mistake and didn't create a separate branch for each fix so that the pull requests contain merged changes from the referenced issues. Most simple solution would be to review and apply the latest commit to that branch which contains all changes from different issues then. Otherwise someone would have to split the single commits into separate branches and connect them to their issues, which is also not too hard. We already invested a lot of time into all these fixes and we're using them in production since month so they should be quite stable. Anyway of course they should be tested by others. We won't invest further time here due to the frustration and lots of unpaid time we had in this project. Thank you :) |
Hi @JPustkuchen, thank you for your answer. |
Thank you @benjamin-ott that sounds great. And please don't take my comments personal. It's not your fault that this project was unmaintained for a long period of time and caused that much frustration. Sorry ;) |
Currently document templates are missing completely in base theme which leads to an error in bootstrap theme and child themes:
I simply copied the templates from Bare theme now.