Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Add (Bare) document templates #39

Open
wants to merge 22 commits into
base: 2.0
Choose a base branch
from

Conversation

JPustkuchen
Copy link

Currently document templates are missing completely in base theme which leads to an error in bootstrap theme and child themes:

Unable to load template snippet 'documents/index_ls.tpl' in engine/Library/Smarty/sysplugins/smarty_internal_templatebase.php on line 127

I simply copied the templates from Bare theme now.

thomasfrobieter and others added 22 commits May 9, 2019 10:56
Added missing include from bare.
Moved frontend_forms_form_elements_form_privacy into the submit form group.
... so we have the checkbox next to the text instead of above.
…dden" - otherwise just the label is printed out.
…type is "hidden". Otherwise just the label is printed out.
Fixed order of supplier info & links like in bootstrap Bare default.
Fixed tabs links in custom parent pages to link to the link instead of the custom page URL, if a custom link is set. Furthermore added data-attributes and target like in menu links.
Added bootstrap document templates
Added document templates from bare to make documents work.
@uehler
Copy link
Member

uehler commented Jul 8, 2020

Hey @JPustkuchen,

thank you for your PR and sorry for the big delay.
Your pull requests contains a lot of unrelated changes, could you fix that please?

and please target the dev branch, which will be merged into the 2.0 branch soon.

@JPustkuchen
Copy link
Author

Same reason as written in my other comments. We made a mistake and didn't create a separate branch for each fix so that the pull requests contain merged changes from the referenced issues.

Most simple solution would be to review and apply the latest commit to that branch which contains all changes from different issues then. Otherwise someone would have to split the single commits into separate branches and connect them to their issues, which is also not too hard. We already invested a lot of time into all these fixes and we're using them in production since month so they should be quite stable. Anyway of course they should be tested by others.

We won't invest further time here due to the frustration and lots of unpaid time we had in this project. Thank you :)

@benjamin-ott
Copy link
Contributor

Hi @JPustkuchen, thank you for your answer.
My colleague is currently on summer vacation and he will have a look at you PRs when he returns.
I'm pretty sure we find a solution (or use your suggested solution) and the PRs can be merged somehow.

@JPustkuchen
Copy link
Author

Thank you @benjamin-ott that sounds great. And please don't take my comments personal. It's not your fault that this project was unmaintained for a long period of time and caused that much frustration. Sorry ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants