Use conda_package_streaming for tarball extraction to avoid umask problems
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
3 tasks
marcoesters
reviewed
Jun 5, 2024
tests/test_main.py
Outdated
Comment on lines
92
to
98
| process = subprocess.Popen( | ||
| [CONDA_EXE, "constructor", "--prefix", tmp_path, "--extract-tarball"], | ||
| stdin=subprocess.PIPE, | ||
| umask=0o022, | ||
| ) | ||
| process.communicate(tarbytes.getvalue()) | ||
| rc = process.wait() |
There was a problem hiding this comment.
Could run_conda be expanded to add stdin strings or is it not worth the effort?
There was a problem hiding this comment.
If we need to send stdin in one more test, I'll do that :P
tests/test_main.py
Outdated
| assert rc == 0 | ||
| if sys.platform != "win32": | ||
| mode = (tmp_path / "naughty_umask").stat().st_mode | ||
| assert not mode & stat.S_IWGRP, "%o" % mode |
There was a problem hiding this comment.
This only checks group writing permissions. This is the origin of the bug, but shouldn't the entire umask be tested?
There was a problem hiding this comment.
Maybe. I copied the logic from Daniel's PR but maybe I can simply test the resulting chmod. Should be 0o777-0o22 right?
There was a problem hiding this comment.
New commit added, hopefully with the expected changes :)
2 tasks
marcoesters
approved these changes
Jun 6, 2024
jezdez
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should help with reports like conda/conda-libmamba-solver#522 and conda-forge/miniforge#506 (comment).
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?