-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CUDA 11.8 w/arch support #84
Rebuild for CUDA 11.8 w/arch support #84
Conversation
…nda-forge-pinning 2023.11.27.19.54.17
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Think we need to add a CUDA 11.8 case (like this one from PyTorch) to this branch logic torchvision-feedstock/recipe/build-torch.sh Lines 17 to 22 in 43854d5
|
Are you able to comment on conda-forge/tensorflow-feedstock#296 i hit the issue with the cuda118 and unclear how it might be related (if at all) |
Don't think it is CUDA 11.8 specific (IOW CUDA 11.2 would have the same issue), but it does look to be a bug in how the The CUDA 12 packages are structured better. So wouldn't expect this issue there (would be interested to know whether that proves out though) |
since the .ci_support files of 11.2 didn't change, I don't think we need a build number bump |
As conda-forge uses CUDA 11.2+, these old CUDA `skip`s can be dropped.
# as of pytorch 1.13, conda-forge only builds for CUDA 11.2+, see | ||
# https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/3491 | ||
skip: true # [cuda_compiler_version in ("10.2", "11.0", "11.1")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped these old CUDA skip
s as conda-forge now uses CUDA 11.2+ ( conda-forge/conda-forge-pinning-feedstock#1708 )
Thanks Mark! 🙏 Dropped some outdated Would it be alright to add the |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This PR has been triggered in an effort to update cuda118.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7013543937, please use this URL for debugging.