Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 11.8 w/arch support #84

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda118.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7013543937, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Think we need to add a CUDA 11.8 case (like this one from PyTorch) to this branch logic

elif [[ ${cuda_compiler_version} == 11.2* ]]; then
export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0;8.6"
else
echo "unsupported cuda version. edit build.sh"
exit 1
fi

@hmaarrfk
Copy link
Contributor

Are you able to comment on conda-forge/tensorflow-feedstock#296

i hit the issue with the cuda118 and unclear how it might be related (if at all)

@jakirkham
Copy link
Member

Don't think it is CUDA 11.8 specific (IOW CUDA 11.2 would have the same issue), but it does look to be a bug in how the cudatoolkit package (used in CUDA 11 and before) is structured. Have responded in that issue ( conda-forge/tensorflow-feedstock#296 (comment) ) and raised a cudatoolkit issue ( conda-forge/cudatoolkit-feedstock#96 )

The CUDA 12 packages are structured better. So wouldn't expect this issue there (would be interested to know whether that proves out though)

@hmaarrfk
Copy link
Contributor

since the .ci_support files of 11.2 didn't change, I don't think we need a build number bump

As conda-forge uses CUDA 11.2+, these old CUDA `skip`s can be dropped.
Comment on lines -23 to -25
# as of pytorch 1.13, conda-forge only builds for CUDA 11.2+, see
# https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/3491
skip: true # [cuda_compiler_version in ("10.2", "11.0", "11.1")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped these old CUDA skips as conda-forge now uses CUDA 11.2+ ( conda-forge/conda-forge-pinning-feedstock#1708 )

@jakirkham
Copy link
Member

Thanks Mark! 🙏

Dropped some outdated skips noted above

Would it be alright to add the automerge label here?

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Nov 29, 2023
@github-actions github-actions bot merged commit cf89794 into conda-forge:main Nov 29, 2023
26 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda118-0-1_h3f4cda branch November 29, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants