Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try building for windows #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Try building for windows #23

wants to merge 4 commits into from

Conversation

h-vetinari
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Part of #22

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Ah, I guess defaults hasn't built pytorch 1.8 yet...

@hmaarrfk
Copy link
Contributor

we should have builds for pytorch 1.8 on conda forge.

It seems that the upload failed for some reason.

I've made a dummy commit. Builds should be up in 3-4 hours. Let me know if they aren't.

hmaarrfk
hmaarrfk reviewed Mar 28, 2021
View reviewed changes
conda-forge.yml
@@ -1,4 +1,5 @@
build_platform: {osx_arm64: osx_64}
channel_priority: flexible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have builds for windows for pytorch right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. They fail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last windows builds on conda-forge are for 1.1.0, which is too old for this recipe...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conda-forge/pytorch-cpu-feedstock#32, will comment there.

@mfansler mfansler mentioned this pull request Apr 7, 2021
Open
@weiji14 weiji14 mentioned this pull request May 3, 2022
Closed
@moorepants
Copy link

Hi, any chance that this might work now? Maybe 3 years of updates in the other packages has an effect.

@h-vetinari
Copy link
Member Author

No, because pytorch still doesn't have windows builds in conda-forge yet (though there are renewed efforts recently).

@moorepants
Copy link

Thanks, I saw the win-64 label on the pytorch-cpu feedstock but now see it is from some old builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@hmaarrfk hmaarrfk hmaarrfk left review comments

@nehaljwani nehaljwani Awaiting requested review from nehaljwani nehaljwani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-vetinari @conda-forge-linter @hmaarrfk @moorepants @isuruf