Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf 2.16, py 3.12, various migrations #385

Merged
merged 49 commits into from
May 23, 2024
Merged

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented May 11, 2024

Based on #379, now that we have the infrastructure from #373.

Check here for updated requirements.

Closes #388
Closes #387
Closes #384
Closes #383
Closes #379
Closes #375
Closes #374
Closes #372
Closes #371

+ python 3.12, protobuf 4.25.3, snappy 1.2

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam
Copy link
Contributor

ngam commented May 17, 2024

Confirmed the same exact fail with osx-64 env, so this is robust.

See below for the config (also btw, feel free to edit these comments to make them readable; I don't know what people prefer)

INFO: Reading rc options for 'build' from /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc:
  'build' options: --config=macos_arm64 --crosstool_top=//custom_toolchain:toolchain --logging=6 --verbose_failures --define=PREFIX=/Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla --define=PROTOBUF_INCLUDE_PATH=/Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include --config=noaws --cpu=darwin_arm64 --local_cpu_resources=2
INFO: Found applicable config definition build:short_logs in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --output_filter=DONT_MATCH_ANYTHING
INFO: Found applicable config definition build:v2 in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1
INFO: Found applicable config definition build:macos_arm64 in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --cpu=darwin_arm64 --macos_minimum_os=11.0
INFO: Found applicable config definition build:noaws in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --define=no_aws_support=true
INFO: Found applicable config definition build:macos in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --apple_platform_type=macos --copt=-DGRPC_BAZEL_BUILD --features=archive_param_file --copt=-w --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --config=no_tfrt
INFO: Found applicable config definition build:no_tfrt in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --deleted_packages=tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/ifrt,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/runtime_fallback/test,tensorflow/core/runtime_fallback/test/gpu,tensorflow/core/runtime_fallback/test/saved_model,tensorflow/core/runtime_fallback/test/testdata,tensorflow/core/tfrt/stubs,tensorflow/core/tfrt/tfrt_session,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python,tensorflow/core/tfrt/saved_model/utils

@ngam
Copy link
Contributor

ngam commented May 17, 2024

The specific code in question was added in openxla/xla@b69a2d9. Not sure if our previous build had this commit ...

@h-vetinari
Copy link
Member Author

What I don't understand is how we can fail on a warning without turning warnings into errors. The config above clearly contains --copt=-w, which is documented to mean "Suppress all warnings", IOW the antithesis of -Werror.

@h-vetinari
Copy link
Member Author

Ah... The joy of vendored packages overriding the defaults and doing their own thing

@h-vetinari
Copy link
Member Author

Ah... The joy of vendored packages overriding the defaults and doing their own thing

Argh, that's a red herring as that file isn't present in 2.16.1...

@h-vetinari
Copy link
Member Author

Could you post the entire log in a gist somewhere?

@xhochy
Copy link
Member

xhochy commented May 17, 2024

See this https://gist.github.com/xhochy/4d73dab51eff5504adfd0698430defc2 for the full compiler line. I don't understand why this warning errors.

@h-vetinari
Copy link
Member Author

That's not so huge that it needs to be in a gist IMO 😅 (though I cleaned up the paths a bit)

[8,602 / 12,407] Compiling xla/mlir_hlo/mhlo/IR/hlo_ops.cc; 60s local ... (8 actions running)
ERROR: $BUILD_PREFIX/share/bazel/d3123197d06fbdfa24ce2d105b5282de/external/local_xla/xla/translate/mhlo_to_hlo/BUILD:70:11: Compiling xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc failed: (Exit 1): cc_wrapper.sh failed: error executing command (from target @local_xla//xla/translate/mhlo_to_hlo:mlir_hlo_to_hlo)
  (cd $BUILD_PREFIX/share/bazel/d3123197d06fbdfa24ce2d105b5282de/execroot/org_tensorflow && \
  exec env - \
    PATH=$SRC_DIR:$BUILD_PREFIX/bin:$PREFIX/bin:/Users/uwe/Development/conda-forge/tensorflow-feedstock/miniforge3/condabin:$BUILD_PREFIX/bin:$PREFIX/bin:/Users/uwe/Development/conda-forge/tensorflow-feedstock/miniforge3/bin:/Users/uwe/mambaforge/condabin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/X11/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:~/.dotnet/tools:/Users/uwe/.local/bin:/Users/uwe/.pixi/bin \
    PWD=/proc/self/cwd \
    PYTHON_BIN_PATH=$PREFIX/bin/python \
    PYTHON_LIB_PATH=$PREFIX/lib/python3.11/site-packages \
    TF2_BEHAVIOR=1 \
    TF_SYSTEM_LIBS=astor_archive,astunparse_archive,boringssl,com_github_googlecloudplatform_google_cloud_cpp,com_github_grpc_grpc,com_google_absl,com_google_protobuf,curl,cython,dill_archive,flatbuffers,gast_archive,gif,icu,libjpeg_turbo,org_sqlite,png,pybind11,snappy,zlib \
  custom_toolchain/cc_wrapper.sh -MD -MF bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.d '-frandom-seed=bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o' -fPIC '-DEIGEN_MAX_ALIGN_BYTES=64' -DEIGEN_ALLOW_UNALIGNED_SCALARS '-DEIGEN_USE_AVX512_GEMM_KERNELS=0' -DTF_USE_SNAPPY '-DLLVM_ON_UNIX=1' '-DHAVE_BACKTRACE=1' '-DBACKTRACE_HEADER=<execinfo.h>' '-DLTDL_SHLIB_EXT=".so"' '-DLLVM_PLUGIN_EXT=".so"' '-DLLVM_ENABLE_THREADS=1' '-DHAVE_DEREGISTER_FRAME=1' '-DHAVE_LIBPTHREAD=1' '-DHAVE_PTHREAD_GETNAME_NP=1' '-DHAVE_PTHREAD_H=1' '-DHAVE_PTHREAD_SETNAME_NP=1' '-DHAVE_REGISTER_FRAME=1' '-DHAVE_SETENV_R=1' '-DHAVE_STRERROR_R=1' '-DHAVE_SYSEXITS_H=1' '-DHAVE_UNISTD_H=1' '-DHAVE_MACH_MACH_H=1' '-DHAVE_MALLOC_MALLOC_H=1' '-DHAVE_MALLOC_ZONE_STATISTICS=1' '-DHAVE_PROC_PID_RUSAGE=1' '-DHAVE_UNW_ADD_DYNAMIC_FDE=1' '-DLLVM_NATIVE_ARCH="X86"' '-DLLVM_NATIVE_ASMPARSER=LLVMInitializeX86AsmParser' '-DLLVM_NATIVE_ASMPRINTER=LLVMInitializeX86AsmPrinter' '-DLLVM_NATIVE_DISASSEMBLER=LLVMInitializeX86Disassembler' '-DLLVM_NATIVE_TARGET=LLVMInitializeX86Target' '-DLLVM_NATIVE_TARGETINFO=LLVMInitializeX86TargetInfo' '-DLLVM_NATIVE_TARGETMC=LLVMInitializeX86TargetMC' '-DLLVM_NATIVE_TARGETMCA=LLVMInitializeX86TargetMCA' '-DLLVM_HOST_TRIPLE="x86_64-unknown-darwin"' '-DLLVM_DEFAULT_TARGET_TRIPLE="x86_64-unknown-darwin"' '-DLLVM_VERSION_MAJOR=19' '-DLLVM_VERSION_MINOR=0' '-DLLVM_VERSION_PATCH=0' '-DLLVM_VERSION_STRING="19.0.0git"' -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS '-DBLAKE3_USE_NEON=0' -DBLAKE3_NO_AVX2 -DBLAKE3_NO_AVX512 -DBLAKE3_NO_SSE2 -DBLAKE3_NO_SSE41 '-DBAZEL_CURRENT_REPOSITORY="local_xla"' -iquote external/local_xla -iquote bazel-out/darwin-opt/bin/external/local_xla -iquote external/com_google_absl -iquote bazel-out/darwin-opt/bin/external/com_google_absl -iquote external/eigen_archive -iquote bazel-out/darwin-opt/bin/external/eigen_archive -iquote external/ml_dtypes -iquote bazel-out/darwin-opt/bin/external/ml_dtypes -iquote external/local_tsl -iquote bazel-out/darwin-opt/bin/external/local_tsl -iquote external/nsync -iquote bazel-out/darwin-opt/bin/external/nsync -iquote external/double_conversion -iquote bazel-out/darwin-opt/bin/external/double_conversion -iquote external/com_google_protobuf -iquote bazel-out/darwin-opt/bin/external/com_google_protobuf -iquote external/snappy -iquote bazel-out/darwin-opt/bin/external/snappy -iquote external/com_googlesource_code_re2 -iquote bazel-out/darwin-opt/bin/external/com_googlesource_code_re2 -iquote external/llvm-project -iquote bazel-out/darwin-opt/bin/external/llvm-project -iquote external/stablehlo -iquote bazel-out/darwin-opt/bin/external/stablehlo -iquote external/farmhash_archive -iquote bazel-out/darwin-opt/bin/external/farmhash_archive -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/int4 -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/float8 -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mlir_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/canonicalize_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/convert_op_folder -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_common -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_pattern_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_typedefs_inc_gen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/ArithCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/AsmParserTokenKinds -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/MLIRShapeCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base_attr_interfaces_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/broadcast_utils -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_type_inference -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_assembly_format -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_structs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_attrdefs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_dialect_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_ops -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_passes -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_chlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_legalize_to_stablehlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_stablehlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_types_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_linalg_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_mhlo_to_scalar_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_standard_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lower_complex_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_hlo_to_lhlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_pass_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_rng_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_scatter_gather_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/shape_component_analysis -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/stablehlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/type_conversion -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/unfuse_batch_norm -isystem external/eigen_archive -isystem bazel-out/darwin-opt/bin/external/eigen_archive -isystem external/eigen_archive/mkl_include -isystem bazel-out/darwin-opt/bin/external/eigen_archive/mkl_include -isystem external/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes -isystem external/ml_dtypes/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes/ml_dtypes -isystem external/nsync/public -isystem bazel-out/darwin-opt/bin/external/nsync/public -isystem external/llvm-project/llvm/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/llvm/include -isystem external/llvm-project/mlir/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/mlir/include -isystem external/farmhash_archive/src -isystem bazel-out/darwin-opt/bin/external/farmhash_archive/src -isystem $PREFIX/include '-march=core2' '-mtune=haswell' -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem $PREFIX/include '-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1' '-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix' '-D_FORTIFY_SOURCE=2' -isystem $PREFIX/include '-mmacosx-version-min=10.13' '-mmacosx-version-min=10.13' '-march=core2' '-mtune=haswell' -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe '-stdlib=libc++' -fvisibility-inlines-hidden '-fmessage-length=0' -isystem $PREFIX/include '-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1' '-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix' '-D_FORTIFY_SOURCE=2' -isystem $PREFIX/include '-mmacosx-version-min=10.13' '-mmacosx-version-min=10.13' -DGRPC_BAZEL_BUILD -w '-std=c++17' -c external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc -o bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o)
# Configuration: cdfb1a5ce32106f8114fc8cac20607fc0b5c61791048b4e8864dad4b71b3e20a
# Execution platform: @local_execution_config_platform//:platform
external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc:176:35: error: non-constant-expression cannot be narrowed from type 'uint64_t' (aka 'unsigned long long') to 'unsigned char' in initializer list [-Wc++11-narrowing]
        array.data()[i] = xla::u4{values[i].getZExtValue()};
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc:176:35: note: insert an explicit cast to silence this issue
        array.data()[i] = xla::u4{values[i].getZExtValue()};
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
                                  static_cast<unsigned char>( )
1 error generated.
CONDA_BUILD_SYSROOT=/opt/MacOSX10.13.sdk x86_64-apple-darwin13.4.0-clang -MD -MF bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.d -frandom-seed=bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o -fPIC -DEIGEN_MAX_ALIGN_BYTES=64 -DEIGEN_ALLOW_UNALIGNED_SCALARS -DEIGEN_USE_AVX512_GEMM_KERNELS=0 -DTF_USE_SNAPPY -DLLVM_ON_UNIX=1 -DHAVE_BACKTRACE=1 -DBACKTRACE_HEADER=<execinfo.h> -DLTDL_SHLIB_EXT=".so" -DLLVM_PLUGIN_EXT=".so" -DLLVM_ENABLE_THREADS=1 -DHAVE_DEREGISTER_FRAME=1 -DHAVE_LIBPTHREAD=1 -DHAVE_PTHREAD_GETNAME_NP=1 -DHAVE_PTHREAD_H=1 -DHAVE_PTHREAD_SETNAME_NP=1 -DHAVE_REGISTER_FRAME=1 -DHAVE_SETENV_R=1 -DHAVE_STRERROR_R=1 -DHAVE_SYSEXITS_H=1 -DHAVE_UNISTD_H=1 -DHAVE_MACH_MACH_H=1 -DHAVE_MALLOC_MALLOC_H=1 -DHAVE_MALLOC_ZONE_STATISTICS=1 -DHAVE_PROC_PID_RUSAGE=1 -DHAVE_UNW_ADD_DYNAMIC_FDE=1 -DLLVM_NATIVE_ARCH="X86" -DLLVM_NATIVE_ASMPARSER=LLVMInitializeX86AsmParser -DLLVM_NATIVE_ASMPRINTER=LLVMInitializeX86AsmPrinter -DLLVM_NATIVE_DISASSEMBLER=LLVMInitializeX86Disassembler -DLLVM_NATIVE_TARGET=LLVMInitializeX86Target -DLLVM_NATIVE_TARGETINFO=LLVMInitializeX86TargetInfo -DLLVM_NATIVE_TARGETMC=LLVMInitializeX86TargetMC -DLLVM_NATIVE_TARGETMCA=LLVMInitializeX86TargetMCA -DLLVM_HOST_TRIPLE="x86_64-unknown-darwin" -DLLVM_DEFAULT_TARGET_TRIPLE="x86_64-unknown-darwin" -DLLVM_VERSION_MAJOR=19 -DLLVM_VERSION_MINOR=0 -DLLVM_VERSION_PATCH=0 -DLLVM_VERSION_STRING="19.0.0git" -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DBLAKE3_USE_NEON=0 -DBLAKE3_NO_AVX2 -DBLAKE3_NO_AVX512 -DBLAKE3_NO_SSE2 -DBLAKE3_NO_SSE41 -DBAZEL_CURRENT_REPOSITORY="local_xla" -iquote external/local_xla -iquote bazel-out/darwin-opt/bin/external/local_xla -iquote external/com_google_absl -iquote bazel-out/darwin-opt/bin/external/com_google_absl -iquote external/eigen_archive -iquote bazel-out/darwin-opt/bin/external/eigen_archive -iquote external/ml_dtypes -iquote bazel-out/darwin-opt/bin/external/ml_dtypes -iquote external/local_tsl -iquote bazel-out/darwin-opt/bin/external/local_tsl -iquote external/nsync -iquote bazel-out/darwin-opt/bin/external/nsync -iquote external/double_conversion -iquote bazel-out/darwin-opt/bin/external/double_conversion -iquote external/com_google_protobuf -iquote bazel-out/darwin-opt/bin/external/com_google_protobuf -iquote external/snappy -iquote bazel-out/darwin-opt/bin/external/snappy -iquote external/com_googlesource_code_re2 -iquote bazel-out/darwin-opt/bin/external/com_googlesource_code_re2 -iquote external/llvm-project -iquote bazel-out/darwin-opt/bin/external/llvm-project -iquote external/stablehlo -iquote bazel-out/darwin-opt/bin/external/stablehlo -iquote external/farmhash_archive -iquote bazel-out/darwin-opt/bin/external/farmhash_archive -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/int4 -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/float8 -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mlir_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/canonicalize_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/convert_op_folder -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_common -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_pattern_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_typedefs_inc_gen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/ArithCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/AsmParserTokenKinds -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/MLIRShapeCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base_attr_interfaces_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/broadcast_utils -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_type_inference -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_assembly_format -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_structs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_attrdefs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_dialect_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_ops -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_passes -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_chlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_legalize_to_stablehlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_stablehlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_types_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_linalg_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_mhlo_to_scalar_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_standard_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lower_complex_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_hlo_to_lhlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_pass_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_rng_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_scatter_gather_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/shape_component_analysis -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/stablehlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/type_conversion -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/unfuse_batch_norm -isystem external/eigen_archive -isystem bazel-out/darwin-opt/bin/external/eigen_archive -isystem external/eigen_archive/mkl_include -isystem bazel-out/darwin-opt/bin/external/eigen_archive/mkl_include -isystem external/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes -isystem external/ml_dtypes/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes/ml_dtypes -isystem external/nsync/public -isystem bazel-out/darwin-opt/bin/external/nsync/public -isystem external/llvm-project/llvm/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/llvm/include -isystem external/llvm-project/mlir/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/mlir/include -isystem external/farmhash_archive/src -isystem bazel-out/darwin-opt/bin/external/farmhash_archive/src -isystem $PREFIX/include -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.13 -mmacosx-version-min=10.13 -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.13 -mmacosx-version-min=10.13 -DGRPC_BAZEL_BUILD -w -std=c++17 -c external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc -o bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o
[8,610 / 12,407] checking cached actions

So the -w is definitely there (towards the end, next to -std=c++17). This sounds like a clang bug...?

I see a couple of upstream issues around -Wc++11-narrowing, but a lot of them are very old. I suggest we try this again with clang 18, and if it still reproduces, I'll raise an issue upstream.

@ngam
Copy link
Contributor

ngam commented May 18, 2024

@h-vetinari, still same problem. Here's a full gist: https://gist.github.com/ngam/33c08e4f38f8760ae1907425361c872d

@h-vetinari
Copy link
Member Author

@h-vetinari, still same problem. Here's a full gist: https://gist.github.com/ngam/33c08e4f38f8760ae1907425361c872d

Thank you! Are you sure it's the right one though? I kind of doubt that your local path is also /Users/uwe/... 😆

@ngam
Copy link
Contributor

ngam commented May 18, 2024

Major oops! Updated in-place 😸

@h-vetinari
Copy link
Member Author

@ngam @xhochy, I applied the workaround suggested upstream, could you try again to see if the build now passes? 🙏

@xhochy
Copy link
Member

xhochy commented May 22, 2024

With the last commit, it passed for me on osx-64.

@h-vetinari
Copy link
Member Author

With the last commit, it passed for me on osx-64.

Thank you for fixing my braino and for testing - great news! 🙏 🥳

Can you and/or @ngam build out the osx{-64,-arm64} matrix?

@h-vetinari
Copy link
Member Author

PS. If you restarted one of the linux builds, there's been no change for those since bf7445a, where they all passed. All that was left was fixing osx.

@ngam
Copy link
Contributor

ngam commented May 22, 2024

Sorry for going disappearing (usg stuff/work) but I can start building Friday when I'm back to home base

@xhochy
Copy link
Member

xhochy commented May 22, 2024

I can start to build osx-64 today and probably osx-arm64 maybe tonight or tomorrow.

@xhochy
Copy link
Member

xhochy commented May 23, 2024

osx-arm64-logs.zip

@xhochy
Copy link
Member

xhochy commented May 23, 2024

osx-64-logs.zip

@xhochy xhochy merged commit dd0d4e5 into conda-forge:main May 23, 2024
3 of 19 checks passed
@h-vetinari h-vetinari deleted the 2.16 branch May 23, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants