-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf 2.16, py 3.12, various migrations #385
Conversation
…nda-forge-pinning 2024.02.23.21.25.19
…nda-forge-pinning 2024.03.10.12.43.11
…nda-forge-pinning 2024.03.10.12.43.11
…nda-forge-pinning 2024.05.11.20.29.32
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Confirmed the same exact fail with osx-64 env, so this is robust. See below for the config (also btw, feel free to edit these comments to make them readable; I don't know what people prefer)
|
The specific code in question was added in openxla/xla@b69a2d9. Not sure if our previous build had this commit ... |
What I don't understand is how we can fail on a warning without turning warnings into errors. The config above clearly contains |
Ah... The joy of vendored packages overriding the defaults and doing their own thing |
Argh, that's a red herring as that file isn't present in 2.16.1... |
Could you post the entire log in a gist somewhere? |
See this https://gist.github.com/xhochy/4d73dab51eff5504adfd0698430defc2 for the full compiler line. I don't understand why this warning errors. |
That's not so huge that it needs to be in a gist IMO 😅 (though I cleaned up the paths a bit)
So the I see a couple of upstream issues around |
…nda-forge-pinning 2024.05.17.12.37.09
@h-vetinari, still same problem. Here's a full gist: https://gist.github.com/ngam/33c08e4f38f8760ae1907425361c872d |
Thank you! Are you sure it's the right one though? I kind of doubt that your local path is also |
Major oops! Updated in-place 😸 |
With the last commit, it passed for me on osx-64. |
Thank you for fixing my braino and for testing - great news! 🙏 🥳 Can you and/or @ngam build out the osx{-64,-arm64} matrix? |
PS. If you restarted one of the linux builds, there's been no change for those since bf7445a, where they all passed. All that was left was fixing osx. |
Sorry for going disappearing (usg stuff/work) but I can start building Friday when I'm back to home base |
I can start to build |
Based on #379, now that we have the infrastructure from #373.
Check here for updated requirements.
Closes #388
Closes #387
Closes #384
Closes #383
Closes #379
Closes #375
Closes #374
Closes #372
Closes #371
+ python 3.12, protobuf 4.25.3, snappy 1.2