Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rattler-build #24

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rgommers
Copy link
Contributor

@rgommers rgommers commented Nov 6, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Converted automatically with:

conda-recipe-manager convert ./recipe/meta.yaml > ./recipe/recipe.yaml

and then bumped the build number and switched to rattler-build in conda-forge.yml manually.

Reduces build time from 4m 43s in the previous PR to 2m 47s in this PR.

Not yet working locally (pytest tests script doesn't find test files), hence the DEBUG commit and Draft status.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ The top level meta key schema_version is unexpected
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipe/recipe.yaml:

  • ℹ️ No valid build backend found for Python recipe for package meson-python using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12413397136. Examine the logs at this URL for more detail.

@rgommers
Copy link
Contributor Author

Ran into both a rattler-build and a conda-smithy bug here. Plus another invalid linter complaint about a missing build backend that I didn't bother to look at yet (meson-python has an in-tree build backend specified by backend-path in pyproject.toml, so there should not be an external one specified). Let's wait for new rattler-build and conda-smithy releases first.

@rgommers
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin

This comment was marked as outdated.

@rgommers
Copy link
Contributor Author

Changing to python_min runs into prefix-dev/rattler-build#1174, so still blocked it looks like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants