-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for libabseil 20240116, libgrp 1.61, libprotobuf 4.25.2 #203
Rebuild for libabseil 20240116, libgrp 1.61, libprotobuf 4.25.2 #203
Conversation
…nda-forge-pinning 2024.03.02.16.55.54
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.04.16.05.00
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.04.20.49.20
We should be using the proper approach to pull in cos7: https://conda-forge.org/docs/maintainer/knowledge_base/#using-centos-7 |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.05.14.24.26
You already get the cos7 image without doing anything. If you need newer glibc, then you need |
conda-forge.yml
Outdated
# Workaround for https://github.com/conda/conda-libmamba-solver/issues/446 | ||
conda_build_tool: conda-build+classic | ||
conda_build_tool: mambabuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend to delete that line entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then we run into conda/conda-libmamba-solver#446
I don’t think so. By default we still have a pin on cdt_name:cos6, see e.g. the recently created feedstock at https://github.com/conda-forge/open3d-feedstock/ which failed after creation because of cos6 (after passing CI on staged-recipes). I’ve seen this quite a few times before. |
You're already on cos7 (as everyone else):
The only cos6 remnant is the sysroot (glibc, kernel headers, etc.). I haven't checked what problems you've had in open3d, but - at the very least here - it's not (or only seemingly) related to cos7. |
If you check the very first CI run after rerendering the open3d feedstock for the first time, you will see that it failed because it tried to use the cos6 CDTs, that conflict with Then adding |
Ok, I am a bit confused how
|
So, let's recap a little:
|
As to be honest I am not knowledgeable enough to attack any of those three issues, one possible option is to get rid of the
Brainstorming possible solutions, we could:
I can't find a solution satisfying all the constraints. I will sleep on this. |
The build number constraint is definitely problematic, so if we can avoid that with an upstream ogre release, that would be best. If you're talking about a conda-forge-only fake release, then I'd make sure not to take unreleased version numbers (so don't use |
Good point, |
Ok, the night has passed. I like the proposal of ogre 1.10.12.1, let's proceed. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.07.20.43.08
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This PR has been triggered in an effort to update libabseil20240116_libgrpc161_libprotobuf4252.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8132857591, please use this URL for debugging.