-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add user map of institutions (WIP) #773
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly structural stuff. LMK when the map is working and I'll take another look
@@ -54,4 +54,7 @@ export default defineConfig({ | |||
}, | |||
}, | |||
}, | |||
optimizeDeps: { | |||
exclude: ['jeep-sqlite/loader'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this doing?
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't need to be here
frontend/package.json
Outdated
@@ -14,7 +14,8 @@ | |||
"lint:fix": "eslint --fix . --ext .vue,.js,.ts --fix --ignore-path .gitignore", | |||
"style": "prettier --check src/", | |||
"style:fix": "prettier --write src/", | |||
"tls": "npm run type-check && npm run test && npm run lint && (npm run style || npm run style:fix)" | |||
"tls": "npm run type-check && npm run test && npm run lint && (npm run style || npm run style:fix)", | |||
"dev": "vite --force" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json and package-lock.json conflict with the main branch. Probably easiest to revert the lockfile, rebase, and rebuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just for testing, right? I'd leave this untracked since it won't get used in production
frontend/src/assets/isocountries.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is used by anything, wouldn't belong in the client assets/ if it was
-seperated codebase and codebase release total counts on the metrics table
-set up the backend to gather institution data for the user map