-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DymoPrint GUI #54
DymoPrint GUI #54
Conversation
add multiline textalign and fontsize replace text for multiline_text mv anchor to center of text add multiline text alignment add fontsize selection change default aligment to left set constants back to default add fixed label length use original font_config.py
Woah!!! This looks amazing!!! 🤯 I've been wanting to make something like this for the longest time, but honestly there was no way I was finding the time. ❤️ My LabelManager PnP is sadly broken, and I've been struggling to find a new one. (I'm in France.) Thus unfortunately it's a bit tough for me to thoroughly test it. I'm hoping that someone else can step up and give a proper review... |
@shoebill-dev, which device model do you have? Would you be willing to review this PR? |
@MooVx, I think you can solve the from __future__ import annotations |
It should be, except for the "Set relative text size" argument because this is solved by percent scalling instead of quantised size here. |
Nice job with the tests! I found a shipper in France and just ordered a used device. I'm guessing it'll be here in ~1 week. |
Magnificent!!!!! |
I just pinged two more recently active commenters in hopes of getting someone else to test this. I'm very eager to get this merged. |
I added changes from #53 here. console & GUI |
Closes #53 Edit: Hmm, maybe it only works with issues |
Great work! Some findings:
Beside that... awesome! |
Thanks so much @MatthiasLohr for the thoughtful review!!! 😁 What is your printer model? Is it the LabelManager PnP? |
LabelManager 280 |
Ok, thanks. I was really hoping to test this with the LabelManager PnP, but I'm otherwise completely convinced, so I'm going to just cut a new semver-minor release and add your remarks as issues to be patched. |
Why the hurry? Just wait until yours arrived? |
I'm really excited and I want to maintain the momentum. But yes, it's more prudent to wait, especially until we figure out what's going on with the test from #46. |
Context menu miss type fixed. Yesterday I receive a new batch of 6mm tapes, and unfortunately, the type size doesn't work properly :( Looks like problem with the bytes alignment to the bottom instead to centre in DymoLabeler class |
This looks amazing! I've got the 280. Bit busy at the moment, so not able to contribute anything. Sure to check it out in the future though. |
I just had a strange thing happen... I'm running Ubuntu, and I encountered the following error while running
I then ran
So then I ran
to install the missing library, and it worked. Then I uninstalled, and it still worked. I'm pretty confused about what happened. In case anyone else runs into this error, or understands what's going on, please write here! |
I had a similar problem. Qt6 is quite new. On my Ubuntu 20.04 I need to first update pip to the newest version and then force reinstall pyqt6. |
I'm also on 20.04. Probably time to upgrade to 22.04, or possibly even the recently released 23.04. |
I just received the LabelManager PnP. Unfortunately with this branch it neither prints nor gives an error. I'll need to do some debugging. |
The code to print the label was indented to where it only ran when using PyUSB, and not with the original HID file mode.
I fixed this for the LabelManager PnP! Thanks a lot!!! |
Closes #53
added GUI Application based on PyQt6
Install for testing
The GUI is available with the command
dymoprint_gui
To switch back to the release version: