ucd2haskell: Refactor #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge refactor of `ucd2haskell`, motivated by similar work in `ghc-internal`. This will prevent this tool from further bit-rotting. - Remove dependency on `streamly`. This package is overkilled here and has an instable API. The version we use is not supported by recent GHCs and non-trivial migration seems to be required at each new version. Furthermore we currently process `String`s, so there is no much benefit. - Mimic the `Fold` type from `streamly` for basic features. Although not mandatory, this avoid changing all the logic. - Use `ByteString` parsers from `unicode-data-parser` [1]. These parsers are shared with the corresponding `ucd2haskell` tool in `base` (now `ghc-internal`). We now have a clear separation between parsers and generators. The Unicode files being very stable, this package should be very stable as well. - Move generators to independent modules. This speeds the compilation up and add more structure to the code base. - Remove many anti-patterns and share more code. The files *generated* by this tool remain identical, although I left some comments to further improve them. [1]: https://hackage.haskell.org/package/unicode-data-parser
wismill
force-pushed
the
ucd2haskell/use-unicode-data-parser
branch
from
a64cc10 to
e476d06
Compare
Also change “exe” to “ucd2haskell” in labels, to make clear what it really built.
wismill
force-pushed
the
ucd2haskell/use-unicode-data-parser
branch
3 times, most recently
from
b648ee7 to
1a2b846
Compare
Just print characters that cannot be tested
wismill
force-pushed
the
ucd2haskell/use-unicode-data-parser
branch
from
1a2b846 to
4e5ba1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge refactor of
ucd2haskell, motivated by similar work inghc-internal. This will prevent this tool from further bit-rotting.streamly. This package is overkilled here and hasan instable API. The version we use is not supported by recent GHCs
and non-trivial migration seems to be required at each new version.
Furthermore we currently process
Strings, so there is no much benefit.Foldtype fromstreamlyfor basic features. Although notmandatory, this avoid changing all the logic.
ByteStringparsers fromunicode-data-parser. These parsersare shared with the corresponding
ucd2haskelltool inbase(nowghc-internal). We now have a clear separation between parsers andgenerators. The Unicode files being very stable, this package should be
very stable as well.
and add more structure to the code base.
The files generated by this tool remain identical, although I left some
comments to further improve them.