Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix it so jupyter_kernel_test runs without error on Windows #92

Closed
wants to merge 37 commits into from

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 13, 2024

This PR will make it so the jupyter kernel tests can run on Windows.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.66%. Comparing base (cd317b2) to head (ad4b4af).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   53.66%   53.66%           
=======================================
  Files          15       15           
  Lines         600      600           
=======================================
  Hits          322      322           
  Misses        278      278           

@mcbarton mcbarton marked this pull request as draft May 13, 2024 11:46
@mcbarton
Copy link
Collaborator Author

The issue appears to be that when running the python tests on Windows that the kernel json cannot be parsed in order to do the tests if I read the output correctly. I will investigate.

@mcbarton mcbarton force-pushed the Fix-Windows-tests branch from aa6daa0 to 36f4c1f Compare May 13, 2024 17:05
@mcbarton
Copy link
Collaborator Author

Tests are now running. Just need to work out why they are failing.

@mcbarton mcbarton changed the title Fix Windows tests Fix it so jupyter_kernel_test runs without error on Windows May 14, 2024
@mcbarton mcbarton marked this pull request as ready for review May 14, 2024 09:35
@mcbarton
Copy link
Collaborator Author

mcbarton commented May 14, 2024

@JohanMabille @vgvassilev @alexander-penev can you review this PR? It makes changes such that the kernels can be parsed on Windows for jupyter_kernel_test , so they can now run. I have stopped the failing tests from running on Windows, and raised it as an issue here #95.

@mcbarton mcbarton closed this May 15, 2024
@mcbarton mcbarton deleted the Fix-Windows-tests branch May 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants