Fixes build issues which occur when building on Apple Silicon #77
Conversation
|
yeah cmake in this project as a whole needs some work |
|
@vgvassilev Any suggestions on this pull request? There is almost certainly a better way to do what I have done with cxxopts, but its the only solution I could get to work on my Macbook. After this pull request is approved, I need to make a change to CppInterOp and I should be able to create a build script for those who want to test xeus-clang-repl on their Apple Silicon Macbooks. |
|
After Github CI workflow failed I realised I need to update Github workflow CI to install xeus-zmq due to my changes, and in the Dockerfile also (and probably a few other places which I haven't realised yet I suspect). Will do this sometime in the next few days. Any other issues raised will be fixed with the commit which fixes this issue. |
|
I have just pushed a commit to that updates the Dockerfile so that it builds on arm. It should be considered a draft, which I plan to refine, now that I have it building. Other known issues left to do are
|
|
@vgvassilev This pull request is ready for review. |
| @@ -45,6 +45,7 @@ RUN \ | |||
| ###libomp-dev \ | |||
| # Other "our" apt installs (development and testing) | |||
| build-essential \ | |||
| clang-15 \ | |||
There was a problem hiding this comment.
In ci.yaml matrix we use clang-runtime==17. Can you use the newer version (17) of the clang runtime here as well? It should be able to since the CI test passes with version 17.
There was a problem hiding this comment.
I used clang-15 as that is the latest version of clang I could find in the apt repository which is available for Ubuntu 22.04 . Also when building llvm-project I had to build version 16 as building version 17 and using this with CppInterOp would build but fail with this command on an arm architechture (I cannot remember off the top of my head what message it failed with). It is not currently possible to switch this build of llvm-project to version 17, as although it passes on x86, it doesn't pass on arm (from tests on my local machine).
Line 329 in ce09338
There was a problem hiding this comment.
Oh, yes. This is a good one. I am misled that conda-forge also has the 17th version, but this is APT.
There was a problem hiding this comment.
I could put a fixme next the part of the dockerfile which builds llvm-project version 16.x , until the issue using 17.x on arm is resolved (I'd raise it as an issue, so that there is a log of what the error is), and put a fixme next to using Clang-15 from apt (when the next LTS version of Ubuntu comes out April next year this would have the latest version of Clang since its in apt repository for version 23.10 of Ubuntu, so would be a quick fix).
| export CC=/usr/bin/clang-15 && \ | ||
| export CXX=/usr/bin/clang++-15 && \ |
| then \ | ||
| export CC=/usr/bin/clang-15 && \ | ||
| export CXX=/usr/bin/clang++-15 && \ | ||
| git clone --depth=1 --branch release/16.x https://github.com/llvm/llvm-project.git && \ |
| cd ./llvm-project/ && \ | ||
| mkdir build && \ | ||
| export LLVM_DIR=$(pwd) && \ | ||
| compgen -G "../CppInterOp/patches/llvm/clang16-*.patch" > /dev/null && find ../CppInterOp/patches/llvm/clang16-*.patch -printf "%f\n" && git apply ../CppInterOp/patches/llvm/clang16-*.patch && \ |
|
There is also an issue where xeus-clang-repl links to its older library instead of the just built one. It isn't specifically related to this PR, but it would be nice to fix. |
Link to xeus-zmq Add option to define where cxxopts folder is (Macbook unable to locate folder without) Change header file xeus/xserver_zmq.hpp to xeus-zmq/xserver_zmq.hpp Add #include <iostream> to include/xeus-clang-repl/xmanager.hpp otherwise errors due to use of std::cerr and others Fixes dockerfile so builds on arm based machines Changes CI to include extra dependencies Added fixme messages to Dockerfile due to issues with arm based build and clang-17
|
Added fixme messages to Dockerfile due to clang-17 issues and build on arm |
| @@ -20,6 +20,7 @@ | |||
|
|
|||
| #include "nlohmann/json.hpp" | |||
|
|
|||
| #include <iostream> | |||
There was a problem hiding this comment.
This is mentioned in the PR description. When building natively on MacOS it would not build without this include due to the use of std::cerr and others
Link to xeus-zmq
Add option to define where cxxopts folder is (Macbook unable to locate folder without)
Change header file xeus/xserver_zmq.hpp to xeus-zmq/xserver_zmq.hpp
Add #include to include/xeus-clang-repl/xmanager.hpp otherwise errors due to use of std::cerr and others
Once fixes were applied I found I could build on Apple Silicon, but not everything in the xeus-clang-repl notebooks worked.
Fixes #74
Fixes #75