Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Cppyy::GetMethodSignature to return list of argument type #111

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Vipul-Cariappa
Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa commented Oct 24, 2024

fixes 2 tests in cppyy

test_doc_features.py::TestADVERTISED::test01_reduction_of_overloads and test_overloads.py::TestOVERLOADS::test02_class_based_overloads_explicit_resolution

@Vipul-Cariappa
Copy link
Collaborator Author

Some tests crash in MacARM. @aaronj0 please look at this. I do not have access to the required hardware here.

@Vipul-Cariappa Vipul-Cariappa force-pushed the bug-fix branch 2 times, most recently from 946cd7a to 3f27471 Compare November 4, 2024 05:12
@Vipul-Cariappa
Copy link
Collaborator Author

@aaronj0, this is ready to be merged only test_functions seg faults in OSX arm. test_functions is an xfail, we will need to set run=False.

Copy link
Collaborator

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vgvassilev vgvassilev merged commit 99f22de into compiler-research:master Nov 4, 2024
6 of 15 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the bug-fix branch November 4, 2024 06:26
Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Nov 4, 2024
Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Nov 4, 2024
vgvassilev pushed a commit to compiler-research/cppyy that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants