fix: name conflict and GetGlobalOperator
#109
Conversation
| @@ -477,7 +477,7 @@ bool Cppyy::AppendTypesSlow(const std::string &name, | |||
| if (!struct_count) | |||
| Cpp::Declare(code.c_str()); // initialize the trampoline | |||
|
|
|||
| std::string var = "__s" + std::to_string(struct_count++); | |||
There was a problem hiding this comment.
__s8 conflicts with some variable/type name.
| TCppIndex_t GetGlobalOperator( | ||
| TCppType_t scope, const std::string& lc, const std::string& rc, const std::string& op) { assert(0 && "GetGlobalOperator");return 0; } | ||
| TCppType_t scope, const std::string& lc, const std::string& rc, const std::string& op) { assert(0 && "GetGlobalOperator");return -1; } |
There was a problem hiding this comment.
GetGlobalOperator is called by BuildOperator at https://github.com/Vipul-Cariappa/CPyCppyy-compiler-research/blob/b59c6b1846b40ba99fc2c5d82cbbfd90401d1667/src/Utility.cxx#L271-L274.
I believe it should be -1 and not 0. By looking at the logic at caller end.
|
ping @vgvassilev @aaronj0 |
|
Looks good to me! Let's wait for the checks to finish before merging |
|
It is failing with OSX cling. |
Looks like it crashes now, instead of just failing previously. I would edit the tag to use |
Fixes 5 previously failing test cases.