Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GetMethodSignature for template functions(cling) #104

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Enable GetMethodSignature for template functions(cling) #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
045f531
Enable GetMethodSignature for template functions(cling)
aaronj0 Jul 12, 2024
3eadfac
Merge branch 'master' into template-signatures
aaronj0 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions clingwrapper/src/clingwrapper.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,8 +1412,26 @@ std::string Cppyy::GetMethodArgDefault(TCppMethod_t method, TCppIndex_t iarg)

std::string Cppyy::GetMethodSignature(TCppMethod_t method, bool show_formal_args, TCppIndex_t max_args)
{
// FIXME : Doesn't work for template functions as it does in cling
return Cpp::GetFunctionSignature(method);
if (Cppyy::IsTemplatedMethod(method)) {
std::ostringstream sig;
sig << "(";
int nArgs = GetMethodNumArgs(method);
if (max_args != (TCppIndex_t)-1) nArgs = std::min(nArgs, (int)max_args);
for (int iarg = 0; iarg < nArgs; ++iarg) {
sig << Cppyy::GetMethodArgTypeAsString(method, iarg);
if (show_formal_args) {
const char* argname = Cppyy::GetMethodArgName(method, iarg).c_str();
if (argname && argname[0] != '\0') sig << " " << argname;
const char* defvalue = Cppyy::GetMethodArgDefault(method, iarg).c_str();
if (defvalue && defvalue[0] != '\0') sig << " = " << defvalue;
}
if (iarg != nArgs-1) sig << (show_formal_args ? ", " : ",");
}
sig << ")";
return sig.str();
}

else return Cpp::GetFunctionSignature(method);
}

std::string Cppyy::GetMethodPrototype(TCppMethod_t method, bool show_formal_args)
Expand Down
Loading