Add xeus-cpp build to ci + remove xeus-clang-repl builds from ci #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 87.65% 79.24% -8.42%
==========================================
Files 4 8 +4
Lines 1742 2997 +1255
==========================================
+ Hits 1527 2375 +848
- Misses 215 622 +407 |
|
Yes, no point in having xeus-clang-repl as part of the builds. They already are bulky enough.. |
mcbarton
changed the title
mcbarton
force-pushed
the
add-xeus-cpp-build-ci
branch
from
65918a4 to
0f23735
Compare
|
@vgvassilev I've added to this PR a commit that removes everything relating to xeus-clang-repl from the ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vgvassilev This PR adds back what is needed to build xeus-cpp as part of the ci. I consider this PR ready for merging, as it was tested previously. It just wasn't merged at the time as CppInterOp wasn't part of compiler-research/xeus-cpp .
Fixes #257