Update GetFunctionNumArgs API for template functions #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -267,21 +267,42 @@ TEST(FunctionReflectionTest, GetFunctionReturnType) { | |||
| } | |||
|
|
|||
| TEST(FunctionReflectionTest, GetFunctionNumArgs) { | |||
| std::vector<Decl*> Decls, SubDecls; | |||
| std::vector<Decl*> Decls, TemplateSubDecls; | |||
There was a problem hiding this comment.
warning: variable 'Decls' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| std::vector<Decl*> Decls, TemplateSubDecls; | |
| std::vector<Decl*> Decls = 0, TemplateSubDecls; |
vgvassilev
reviewed
Apr 5, 2024
lib/Interpreter/CppInterOp.cpp
Outdated
| @@ -831,6 +831,11 @@ namespace Cpp { | |||
| if (auto *FD = llvm::dyn_cast_or_null<FunctionDecl>(D)) { | |||
| return FD->getNumParams(); | |||
| } | |||
|
|
|||
| if (auto* FD = llvm::dyn_cast_or_null<clang::FunctionTemplateDecl>(D)) { | |||
There was a problem hiding this comment.
No braces on single line statements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 78.80% 78.82% +0.01%
==========================================
Files 8 8
Lines 3100 3102 +2
==========================================
+ Hits 2443 2445 +2
Misses 657 657
|
aaronj0
force-pushed
the
update-argcount-api
branch
from
4ec804c to
cac4731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.