Update GetFunctionReturnType API for template functions #218

aaronj0 · 2024-04-05T13:43:34Z

No description provided.

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-05T14:07:42Z

unittests/CppInterOp/FunctionReflectionTest.cpp

@@ -228,7 +228,7 @@ TEST(FunctionReflectionTest, GetFunctionsUsingName) {
 }

 TEST(FunctionReflectionTest, GetFunctionReturnType) {
-  std::vector<Decl*> Decls, SubDecls;
+  std::vector<Decl*> Decls, SubDecls, TemplateSubDecls;


warning: variable 'Decls' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<Decl*> Decls, SubDecls, TemplateSubDecls;

std::vector<Decl*> Decls = 0, SubDecls, TemplateSubDecls;

github-actions · 2024-04-05T14:07:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

-  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[5])), "Switch");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[4])),
+            "double");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[5])),


warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers]

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[5])), ^

github-actions · 2024-04-05T14:07:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

-  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])), "volatile N::C");
-  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])), "const volatile N::C");
-  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])), "NULL TYPE");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[7])),


warning: 7 is a magic number; consider replacing it with a named constant [readability-magic-numbers]

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[7])), ^

github-actions · 2024-04-05T14:07:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

-  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])), "NULL TYPE");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[7])),
+            "N::C *");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[8])),


warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers]

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[8])), ^

github-actions · 2024-04-05T14:07:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+            "N::C *");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[8])),
+            "const N::C");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])),


warning: 9 is a magic number; consider replacing it with a named constant [readability-magic-numbers]

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])), ^

github-actions · 2024-04-05T14:07:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+            "const N::C");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])),
+            "volatile N::C");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])),


warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers]

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])), ^

github-actions · 2024-04-05T14:07:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+            "volatile N::C");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])),
+            "const volatile N::C");
+  EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])),


warning: 11 is a magic number; consider replacing it with a named constant [readability-magic-numbers]

EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])), ^

vgvassilev · 2024-04-05T14:48:32Z

lib/Interpreter/CppInterOp.cpp

@@ -822,6 +822,10 @@ namespace Cpp {
        return FD->getReturnType().getAsOpaquePtr();
    }

+    if (auto* FD = llvm::dyn_cast_or_null<clang::FunctionTemplateDecl>(D)) {


Can D be null here? If not we need to drop the _or_null part.

codecov · 2024-04-05T14:54:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (32efeba) to head (173fea8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   78.80%   78.82%   +0.01%     
==========================================
  Files           8        8              
  Lines        3100     3102       +2     
==========================================
+ Hits         2443     2445       +2     
  Misses        657      657

Files	Coverage Δ
lib/Interpreter/CppInterOp.cpp	`86.44% <100.00%> (+0.01%)`	⬆️

Files	Coverage Δ
lib/Interpreter/CppInterOp.cpp	`86.44% <100.00%> (+0.01%)`	⬆️

vgvassilev

LGTM!

Update GetFunctionReturnType

7fb0ae1

github-actions bot reviewed Apr 5, 2024

View reviewed changes

vgvassilev reviewed Apr 5, 2024

View reviewed changes

Update unittests

173fea8

aaronj0 force-pushed the update-returntype-api branch from ca6e56c to 173fea8 Compare April 5, 2024 15:11

vgvassilev approved these changes Apr 7, 2024

View reviewed changes

vgvassilev merged commit c13391b into compiler-research:main Apr 7, 2024
44 checks passed

aaronj0 deleted the update-returntype-api branch April 22, 2024 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GetFunctionReturnType API for template functions #218

Update GetFunctionReturnType API for template functions #218

aaronj0 commented Apr 5, 2024

github-actions bot left a comment

github-actions bot Apr 5, 2024

github-actions bot Apr 5, 2024

github-actions bot Apr 5, 2024

github-actions bot Apr 5, 2024

github-actions bot Apr 5, 2024

github-actions bot Apr 5, 2024

github-actions bot Apr 5, 2024

vgvassilev Apr 5, 2024

codecov bot commented Apr 5, 2024 •

edited

Loading

vgvassilev left a comment

	std::vector<Decl*> Decls, SubDecls, TemplateSubDecls;
	std::vector<Decl*> Decls = 0, SubDecls, TemplateSubDecls;

Update GetFunctionReturnType API for template functions #218

Update GetFunctionReturnType API for template functions #218

Conversation

aaronj0 commented Apr 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

vgvassilev Apr 5, 2024

Choose a reason for hiding this comment

codecov bot commented Apr 5, 2024 • edited Loading

Codecov Report

vgvassilev left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 5, 2024 •

edited

Loading