Add testing infrastructure for the DynamicLibraryManager #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Smit1603 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
289
to
293
| } else { | ||
| LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | ||
| << "is not a shared library\n"); | ||
| return std::string(); | ||
| } |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [llvm-else-after-return]
Suggested change
| } else { | |
| LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | |
| << "is not a shared library\n"); | |
| return std::string(); | |
| } | |
| } LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | |
| << "is not a shared library\n"); | |
| return std::string(); | |
| @@ -0,0 +1,8 @@ | |||
| #include "gtest/gtest.h" | |||
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include "gtest/gtest.h"
^| @@ -0,0 +1,2 @@ | |||
|
|
|||
There was a problem hiding this comment.
warning: header is missing header guard [llvm-header-guard]
Suggested change
| #ifndef GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
| #define GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
unittests/CppInterOp/TestSharedLib/TestSharedLib.h:-1:
+
+ #endif
vgvassilev
force-pushed
the
dynamic-lib-man-tests
branch
from
88f6bd4 to
10a0f5a
Compare
Comment on lines
289
to
293
| } else { | ||
| LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | ||
| << "is not a shared library\n"); | ||
| return std::string(); | ||
| } |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [llvm-else-after-return]
Suggested change
| } else { | |
| LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | |
| << "is not a shared library\n"); | |
| return std::string(); | |
| } | |
| } LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | |
| << "is not a shared library\n"); | |
| return std::string(); | |
vgvassilev
force-pushed
the
dynamic-lib-man-tests
branch
2 times, most recently
from
fcc9794 to
3b50482
Compare
Comment on lines
289
to
293
|
|
||
| LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | ||
| << "is not a shared library\n"); | ||
| return std::string(); | ||
| } |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [llvm-else-after-return]
Suggested change
| LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | |
| << "is not a shared library\n"); | |
| return std::string(); | |
| } | |
| } LLVM_DEBUG(dbgs() << "Dyld::lookupLibrary: '" << libStem.str() << "'" | |
| << "is not a shared library\n"); | |
| return std::string(); | |
| @@ -0,0 +1,6 @@ | |||
| #ifndef UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |||
There was a problem hiding this comment.
warning: header is missing header guard [llvm-header-guard]
Suggested change
| #ifndef UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
| #ifndef GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
| #define GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
unittests/CppInterOp/TestSharedLib/TestSharedLib.h:-1:
+
+ #endif
vgvassilev
force-pushed
the
dynamic-lib-man-tests
branch
from
3b50482 to
72624fd
Compare
Comment on lines
+1
to
+2
| #ifndef UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | ||
| #define UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H |
There was a problem hiding this comment.
warning: header guard does not follow preferred style [llvm-header-guard]
Suggested change
| #ifndef UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
| #define UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
| #ifndef GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H | |
| #define GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H |
unittests/CppInterOp/TestSharedLib/TestSharedLib.h:5:
- #endif // UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H
+ #endif // GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB_H
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 65.85% 70.31% +4.45%
==========================================
Files 17 19 +2
Lines 4326 4332 +6
==========================================
+ Hits 2849 3046 +197
+ Misses 1477 1286 -191
... and 4 files with indirect coverage changes
|
|
The failures are preexisting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.