Remove unused filter param

compiler-research · Apr 4, 2024 · ea63124 · ea63124
1 parent 4ef5e76
commit ea63124
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/include/clang/Interpreter/CppInterOp.h b/include/clang/Interpreter/CppInterOp.h
@@ -339,9 +339,8 @@ namespace Cpp {
                                              TCppScope_t parent = nullptr);
 
   CPPINTEROP_API std::vector<TCppFunction_t>
-  GetTemplatedMethods(const std::string& name, TCppScope_t parent = nullptr,
-                      const std::string& filter = "");
-
+  GetTemplatedMethods(const std::string& name, TCppScope_t parent = nullptr);
+
   /// Checks if the provided parameter is a method.
   CPPINTEROP_API bool IsMethod(TCppConstFunction_t method);
 

diff --git a/lib/Interpreter/CppInterOp.cpp b/lib/Interpreter/CppInterOp.cpp
@@ -730,17 +730,16 @@ namespace Cpp {
       if (D && isa<CXXRecordDecl>(D)) {
         auto* CXXRD = dyn_cast<CXXRecordDecl>(D);
         getSema().ForceDeclarationOfImplicitMembers(CXXRD);
-          for (Decl* DI : CXXRD->decls()) {
-            if (auto* MD = dyn_cast<CXXMethodDecl>(DI))
+        for (Decl* DI : CXXRD->decls()) {
+          if (auto* MD = dyn_cast<CXXMethodDecl>(DI))
+            methods.push_back(MD);
+          else if (auto* USD = dyn_cast<UsingShadowDecl>(DI))
+            if (auto* MD = dyn_cast<CXXMethodDecl>(USD->getTargetDecl()))
               methods.push_back(MD);
-            else if (auto* USD = dyn_cast<UsingShadowDecl>(DI))
-              if (auto* MD = dyn_cast<CXXMethodDecl>(USD->getTargetDecl()))
-                methods.push_back(MD);
         }
       }
     }
   }
-
 
   void GetFunctionTemplatedDecls(TCppScope_t klass,
                                  std::vector<TCppFunction_t>& methods) {
@@ -763,7 +762,6 @@ namespace Cpp {
       }
     }
   }
-
 
   bool HasDefaultConstructor(TCppScope_t scope) {
     auto *D = (clang::Decl *) scope;
@@ -979,8 +977,7 @@ namespace Cpp {
   }
 
   std::vector<TCppFunction_t> GetTemplatedMethods(const std::string& name,
-                                                  TCppScope_t parent,
-                                                  const std::string& filter) {
+                                                  TCppScope_t parent) {
 
     auto* D = (Decl*)parent;