update Cppyy::GetDatamemberOffset to handle multiple inheritance #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Dec 19, 2024
src/Cppyy.h
Outdated
| @@ -324,7 +324,7 @@ namespace Cppyy { | |||
| CPPYY_IMPORT | |||
| std::string GetDatamemberTypeAsString(TCppScope_t var); | |||
| CPPYY_IMPORT | |||
| intptr_t GetDatamemberOffset(TCppScope_t var); | |||
| intptr_t GetDatamemberOffset(TCppScope_t var, TCppScope_t parent = nullptr); | |||
There was a problem hiding this comment.
We can get the enclosing scope from var here, can't we?
There was a problem hiding this comment.
It is not possible in the case of derived class.
var->getParent() will return the base class.
But we want to calculate the offset with respect to the derived class.
There was a problem hiding this comment.
In that case then we should change the name of the parameter. It is not parent according to your description.
Vipul-Cariappa
force-pushed
the
dev/offset-inheritance
branch
from
046149e to
0e93ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on compiler-research/cppyy-backend#118
And that in turn depends on this PR.
There is a cyclic dependency here.