fix type converters function resolution #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
commented
Oct 29, 2024
| PyType_Type.tp_setattro(pyclass, pyname, attr); | ||
| else | ||
| PyType_Type.tp_setattro((PyObject*)Py_TYPE(pyclass), pyname, attr); | ||
| PyType_Type.tp_setattro((PyObject*)Py_TYPE(pyclass), pyname, attr); |
There was a problem hiding this comment.
Doing the same as upstream.
Vipul-Cariappa
commented
Oct 29, 2024
Comment on lines
530
to
+535
| // are needed to prevent unnecessary lookups and recursion. | ||
| if (((CPPScope*)pyclass)->fFlags & CPPScope::kIsNamespace) { | ||
| // skip if the given pyval is a descriptor already, or an unassignable class | ||
| if (!CPyCppyy::CPPDataMember_Check(pyval) && !CPyCppyy::CPPScope_Check(pyval)) { | ||
| std::string name = CPyCppyy_PyText_AsString(pyname); | ||
| if (Cppyy::GetNamed(name, ((CPPScope*)pyclass)->fCppType)) | ||
| meta_getattro(pyclass, pyname); // triggers creation | ||
| } | ||
| if (!CPyCppyy::CPPDataMember_Check(pyval) && !CPyCppyy::CPPScope_Check(pyval)) { | ||
| std::string name = CPyCppyy_PyText_AsString(pyname); | ||
| if (Cppyy::GetNamed(name, ((CPPScope*)pyclass)->fCppType)) | ||
| meta_getattro(pyclass, pyname); // triggers creation |
There was a problem hiding this comment.
This makes sure that meta_getattro is called. Later tp_setattro calls dm_set. Raising the TypeError. Otherwise tp_setattro calls generic setattr.
Vipul-Cariappa
force-pushed
the
bug-fix
branch
from
ce0b710 to
0cba8db
Compare
|
Running the 3 failing tests separately, they pass. As a temporary workaround, can we wrap the ping @aaronj0 |
Vipul-Cariappa
force-pushed
the
bug-fix
branch
from
0cba8db to
afdff88
Compare
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 8, 2024
changes to make sure `dm_set` is called when assigning a value to an enum resulting in raising TypeError
Vipul-Cariappa
force-pushed
the
bug-fix
branch
from
8864627 to
025733e
Compare
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 16, 2024
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 16, 2024
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 16, 2024
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 16, 2024
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 16, 2024
vgvassilev
pushed a commit
to compiler-research/cppyy
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.