update unify cycles

CHANGELOG.md

@@ -19,6 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 * Fixed `PluginNotInstalledError` when using `Brep.from_boolean_*` in Rhino.
+* Expose the parameters `radius` and `nmax` from `compas.topology._face_adjacency` to `compas.topology.face_adjacency` and further propagate them to `unify_cycles` and `Mesh.unify_cycles`.
+* Modify `face_adjacency` to avoid using `compas.topology._face_adjacency` by default when there are more than 100 faces, unless one of the parameters `radius`, `nmax` is passed
 * Added support for `Polyline` as input for `compas_rhino.Brep.from_extrusion`.
 
 ### Removed

src/compas/datastructures/mesh/mesh.py

@@ -2932,9 +2932,18 @@ def quads_to_triangles(self, check_angles=False):
                     del self.facedata[face]
 
     # only reason this is here and not on the halfedge is because of the spatial tree
-    def unify_cycles(self, root=None):
+    def unify_cycles(self, root=None, nmax=None, radius=None):
         """Unify the cycles of the mesh.
 
+        Parameters
+        ----------
+        root : str, optional
+            The key of the root face.
+        nmax : int, optional
+            The maximum number of neighboring faces to consider. If neither nmax nor radius is specified, all faces will be considered.
+        radius : float, optional
+            The radius of the search sphere for neighboring faces. If neither nmax nor radius is specified, all faces will be considered.
+
         Returns
         -------
         None
@@ -2951,7 +2960,7 @@ def unify_cycles(self, root=None):
         vertices = self.vertices_attributes("xyz")
         faces = [[vertex_index[vertex] for vertex in self.face_vertices(face)] for face in self.faces()]
 
-        unify_cycles(vertices, faces)
+        unify_cycles(vertices, faces, root=root, nmax=nmax, radius=radius)
 
         self.halfedge = {key: {} for key in self.vertices()}
         for index, vertices in enumerate(faces):

src/compas/topology/orientation.py

@@ -94,7 +94,7 @@
     return adjacency
 
 
-def face_adjacency(points, faces):
+def face_adjacency(points, faces, nmax=None, radius=None):
     """Build a face adjacency dict.
 
     Parameters
@@ -103,6 +103,10 @@
         The vertex locations of the faces.
     faces : list[list[int]]
         The faces defined as list of indices in the points list.
+    nmax : int, optional
+        The maximum number of neighboring faces to consider. If neither nmax nor radius is specified, all faces will be considered.
+    radius : float, optional
+        The radius of the search sphere for neighboring faces. If neither nmax nor radius is specified, all faces will be considered.
 
     Returns
     -------
@@ -117,10 +121,12 @@
     purely geometrical, but uses a spatial indexing tree to speed up the search.
 
     """
-    f = len(faces)
-
-    if f > 100:
-        return _face_adjacency(points, faces)
+    if nmax is not None:
+        if radius is not None:
+            return _face_adjacency(points, faces, nmax=nmax, radius=radius)
+        return _face_adjacency(points, faces, nmax=nmax)
+    if radius is not None:
+        return _face_adjacency(points, faces, radius=radius)
 
     adjacency = {}
 
@@ -152,7 +158,7 @@
     return adjacency
 
 
-def unify_cycles(vertices, faces, root=None):
+def unify_cycles(vertices, faces, root=None, nmax=None, radius=None):
     """Unify the cycle directions of all faces.
 
     Unified cycle directions is a necessary condition for the data structure to
@@ -166,6 +172,10 @@
         The faces of the mesh defined as lists of vertex indices.
     root : str, optional
         The key of the root face.
+    nmax : int, optional
+        The maximum number of neighboring faces to consider. If neither nmax nor radius is specified, all faces will be considered.
+    radius : float, optional
+        The radius of the search sphere for neighboring faces. If neither nmax nor radius is specified, all faces will be considered.
 
     Returns
     -------
@@ -196,7 +206,7 @@
     if root is None:
         root = random.choice(list(range(len(faces))))
 
-    adj = face_adjacency(vertices, faces)  # this is the only place where the vertex coordinates are used
+    adj = face_adjacency(vertices, faces, nmax=nmax, radius=radius)  # this is the only place where the vertex coordinates are used
 
     visited = breadth_first_traverse(adj, root, unify)