Just use visible locations (#2506)

communitiesuk · Jul 15, 2024 · 9e35b26 · 9e35b26
1 parent fe82a8e
commit 9e35b26
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/helpers/question_view_helper.rb b/app/helpers/question_view_helper.rb
@@ -26,8 +26,8 @@ def answer_option_synonyms(resource)
   def answer_option_append(resource)
     return unless resource.instance_of?(Scheme)
 
-    confirmed_locations_count = resource.locations.confirmed.size
-    unconfirmed_locations_count = resource.locations.unconfirmed.size
+    confirmed_locations_count = resource.locations.visible.confirmed.size
+    unconfirmed_locations_count = resource.locations.visible.unconfirmed.size
     "#{confirmed_locations_count} completed #{'location'.pluralize(confirmed_locations_count)}, #{unconfirmed_locations_count} incomplete #{'location'.pluralize(unconfirmed_locations_count)}"
   end
 

diff --git a/app/views/schemes/_scheme_list.html.erb b/app/views/schemes/_scheme_list.html.erb
@@ -25,7 +25,7 @@
           <% row.with_cell(text: simple_format(scheme_cell(scheme), { class: "govuk-!-font-weight-bold scheme-name-cell" }, wrapper_tag: "div")) %>
           <% row.with_cell(text: scheme.owning_organisation&.name) %>
           <% row.with_cell(text: scheme.id_to_display) %>
-          <% row.with_cell(text: scheme.locations&.count) %>
+          <% row.with_cell(text: scheme.locations.visible&.count) %>
           <% row.with_cell(text: status_tag_from_resource(scheme)) %>
         <% end %>
       <% end %>