CLDC-3289 Avoid freezing time (part 3) (#2445)

* Refactor tests #1 * Update tasklist helper tests * Update task list helper * Fix test * Rabase fixes * Update model/validations tests * Update som sales log specs * Remove missing addresses csv tasks * Update some tests for 2023 collection close * More fixes * Revert sales shared examples change * Fix test * Update test nemes, remove time stub
communitiesuk · Jul 16, 2024 · 8ce22d3 · 8ce22d3
1 parent 3adfb29
commit 8ce22d3
Show file tree

Hide file tree

Showing 23 changed files with 26 additions and 2,195 deletions.
diff --git a/app/jobs/create_addresses_csv_job.rb b/app/jobs/create_addresses_csv_job.rb
diff --git a/app/jobs/email_missing_addresses_csv_job.rb b/app/jobs/email_missing_addresses_csv_job.rb
diff --git a/app/models/derived_variables/sales_log_variables.rb b/app/models/derived_variables/sales_log_variables.rb
@@ -31,7 +31,7 @@ def set_derived_fields!
 
     if saledate && form.start_year_after_2024? && discounted_ownership_sale?
       self.ppostcode_full = postcode_full
-      self.ppcodenk = 0 if postcode_full.present?
+      self.ppcodenk = pcodenk
       self.prevloc = la
       self.is_previous_la_inferred = is_la_inferred
       self.previous_la_known = la_known

diff --git a/app/services/csv/missing_addresses_csv_service.rb b/app/services/csv/missing_addresses_csv_service.rb
diff --git a/lib/tasks/import_address_from_csv.rake b/lib/tasks/import_address_from_csv.rake