PRSD-642: Landlord Registration Confirmation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionNumberDataModel
…red landlord creation method
…urney post request
…ests for Confirmation step
isobel-softwire
force-pushed
the
feat/PRSD-642-landlord-registration-confirmation
branch
from
eb25bab to
6af8257
Compare
AEPR
requested changes
Dec 12, 2024
...main/kotlin/uk/gov/communities/prsdb/webapp/models/dataModels/RegistrationNumberDataModel.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/forms/journeys/LandlordRegistrationJourney.kt
Outdated
Show resolved
Hide resolved
src/main/resources/templates/registerAsALandlordConfirmation.html
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/helpers/DateTimeHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/helpers/DateTimeHelper.kt
Outdated
Show resolved
Hide resolved
isobel-softwire
force-pushed
the
feat/PRSD-642-landlord-registration-confirmation
branch
from
a56ee56 to
b820e55
Compare
Kiran-R-K
reviewed
Dec 13, 2024
| phoneNumPage.phoneNumberInput.fill("07123456789") | ||
| phoneNumPage.form.submit() | ||
| assertPageIs(page, CountryOfResidenceFormPageLandlordRegistration::class) | ||
|
|
||
| val countryOfResidencePage = navigator.goToLandlordRegistrationCountryOfResidencePage() |
There was a problem hiding this comment.
I think this should be assertIsPage not navigator.goTo...., this should be changed on all these User can navigate tests (I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overarching Changes
JourneyDataServicethat help with retrieving values from the sessionLandlordRegistrationJourneyTeststoNavigatorLandlordRegistrationJourneyTestsFeatures
/confirmationendpoint and template for landlord registration journeyDeclarationstep'shandleSubmitAndRedirectto create a landlord, clear the session's journey data, and return the/confirmationendpointScreenshots
Tests