Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DB migrations in CI #28

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

samuelhwilliams
Copy link
Contributor

@samuelhwilliams samuelhwilliams commented Dec 5, 2024

https://mhclgdigital.atlassian.net/browse/FSPT-153

Change description

Pre-award-stores uses Alembic to manage DB migrations, helping to update the structure of our DB tables when the related Python models change.

In some of the non-consolidated pre-award-stores, we saw that the structure of the DB was not actually in sync with the Python models because some migration steps were missed.

This CI check will fail if there are any pending alembic migrations that need generating.

@samuelhwilliams samuelhwilliams marked this pull request as ready for review December 5, 2024 10:12
@samuelhwilliams samuelhwilliams force-pushed the bau/check-alembic-migrations branch 2 times, most recently from 8a86e77 to af75cf0 Compare December 5, 2024 10:14
@samuelhwilliams samuelhwilliams changed the title WIP: check DB migrations in CI Check DB migrations in CI Dec 5, 2024
Copy link

sonarqubecloud bot commented Dec 5, 2024

@samuelhwilliams samuelhwilliams merged commit 4c77325 into main Dec 5, 2024
15 checks passed
@samuelhwilliams samuelhwilliams deleted the bau/check-alembic-migrations branch December 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants