FSPT-208 Script to make nested JSON date strings consistent #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a ~2 week period application `date_submitted` properties were incorrectly set with timezone information (in this case consistently UTC with `+00.00`). The consumer of these dates (the assess tool) has been updated in places to parse any valid ISO format but leaving different formats of dates could lead to unpredictiable behaviour. Update existing assessment records to make this consistent.
sfount
force-pushed
the
FSPT-208-update-existing-data
branch
from
4267220 to
1b8a2bc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a ~2 week period application
date_submittedproperties were incorrectly set with timezone information (in this case consistently UTC with+00.00).The consumer of these dates (the assess tool) has been updated in places to parse any valid ISO format but leaving different formats of dates could lead to unpredictable behaviour.
Update existing assessment records to make this consistent.
Depends on #126