FSPT-190 Get the account store URI from the parameter store #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just point to the new store, this will likely become scheduled job on the main app to reduce moving parts, fine for it to be fixed for now
sfount
force-pushed
the
FSPT-190-get-account-store-host-from-param-store
branch
from
55b4de2 to
1f253e2
Compare
samuelhwilliams
approved these changes
Dec 18, 2024
samuelhwilliams
deleted the
FSPT-190-get-account-store-host-from-param-store
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just point to the new store, this will likely become scheduled job on
the main app to reduce moving parts, fine for it to be fixed for now
Previous commit (fetching from SSM doesn't appear to be supported by the lambda resource in the addons):
This should allow the environment variable to be retrieved from the param store at the time that this is run.Note that similar to an ECS task definition this will only set the environment for the lambda at the time that this is run, the lambda will then use that value unless its deployed again (which presumably happens a lot less than the apps).If we wanted to guarantee the lambda was using the latest references to stores in the param store (unlikely as we're reducing our data stores down to one database) we could use a lambda extension layer as described in:https://docs.aws.amazon.com/systems-manager/latest/userguide/ps-integration-lambda-extensions.html
Disclaimer: I haven't tried this and have no idea if it even makes sense.