Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-4533 adding fix_default_page_ids to clone round #40

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

srh-sloan
Copy link
Contributor

Change description

Fixes a bug whereby if you clone an entire round it wasn't updating the default_next_page_id column of the cloned pages. Fixed this and updated unit tests

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

  • Clone a round that contains forms
  • Use 'View all application questions' to view the whole application and it should work (previously failing)

Screenshots of UI changes (if applicable)

Copy link
Contributor

@NarenderRajuB NarenderRajuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srh-sloan srh-sloan merged commit 6f25c1e into main Sep 18, 2024
13 checks passed
@srh-sloan srh-sloan deleted the fs-4533-fix-clone-round branch September 18, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants