FS-4917 - Remove unused code #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
71000f9 to
1013810
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
1013810 to
70717ee
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
70717ee to
b58339e
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
b58339e to
95950ad
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
95950ad to
e626462
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
e626462 to
315a802
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
315a802 to
a079a05
Compare
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
a079a05 to
07eeec1
Compare
These routes were mounted at `/dev` and provided local development and debugging functionality that was not being actively used.
This self-serve system was a prototype for constructing forms from lower-level components, built on top of an in-memory "database". Such low-level form construction is not currently within the scope of FAB as a production asset. We also tidy up usage of the helper functions human_to_kebab_case and human_to_snake_case, which were previously duplicated and imported from the routes file in the self-serve directory.
…irectory These tasks were developer tools for seeding and manipulating the local database, as well as to manually generate export files. None of this stuff was linked to the frontend. Seeding the local database for unit tests is still required, and so this has been moved to a new place.
We have some docker-compose and .devcontainer stuff that isn't used. Rather, we should run FAB from the global Docker Runner - funding-service-design-docker-runner.
wjrm500
force-pushed
the
FS-4917_remove-unused-code
branch
from
07eeec1 to
05d0651
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://mhclgdigital.atlassian.net/browse/FS-4917
Changes
Remove unused dev routes - These routes were mounted at
/devand provided local development and debugging functionality that was not being actively used.Remove unused self-serve functionality - This self-serve system was a prototype for constructing forms from lower-level components, built on top of an in-memory "database". Such low-level form construction is not currently within the scope of FAB as a production asset. We also tidy up usage of the helper functions human_to_kebab_case and human_to_snake_case, which were previously duplicated and imported from the routes file in the self-serve directory.
Remove unused tasks and move test data seeding into tests directory
These tasks were developer tools for seeding and manipulating the local database, as well as to manually generate export files. None of this stuff was linked to the frontend. Seeding the local database for unit tests is still required, and so this has been moved to a new place.
Remove redundant local development config - We have some docker-compose and .devcontainer stuff that isn't used. Rather, we should run FAB from the global Docker Runner - funding-service-design-docker-runner.