Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-4833 - Adding basic auth to FAB #150

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

wjrm500
Copy link
Contributor

@wjrm500 wjrm500 commented Dec 13, 2024

Ticket

Add basic auth to FAB for pre-prod environments

Description

Following the convention of other apps including Authenticator, we can use an Nginx sidecar to seamlessly provide basic auth on all HTTP requests, while allowing requests to /healthcheck through.

We have only added to Dev and Test environments, not UAT as this will be our de facto prod environment for the January delivery, and will be authenticated by Entra ID.

Note that we also need to ensure values are in the AWS Parameter Store to support this change.

Copy link

sonarcloud bot commented Dec 16, 2024

Copy link
Contributor

@hamzabinkhalid hamzabinkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@wjrm500 wjrm500 merged commit f3c6df6 into main Dec 16, 2024
12 checks passed
@wjrm500 wjrm500 deleted the FS-4833_add-basic-auth-to-fab branch December 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants