-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS-4805 - Adding authentication to FAB #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
November 29, 2024 17:30
9f820fa
to
31afc3a
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 4, 2024 11:28
31afc3a
to
5582660
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 6, 2024 11:48
5582660
to
eba29fa
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 6, 2024 11:49
eba29fa
to
35e6a7f
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 6, 2024 12:27
35e6a7f
to
cc1f11d
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 6, 2024 17:58
cc1f11d
to
dcccc5a
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 6, 2024 18:53
dcccc5a
to
d8e4ab1
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 6, 2024 18:55
d8e4ab1
to
2a2d776
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 7, 2024 08:41
2a2d776
to
ad86ef6
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 7, 2024 09:12
ad86ef6
to
ef957f4
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 7, 2024 09:14
ef957f4
to
e5cc1e4
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 10, 2024 12:24
1c70fd3
to
32243c0
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 10, 2024 14:09
32243c0
to
209ce70
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 10, 2024 16:30
1053fea
to
f892c72
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 10, 2024 16:30
f892c72
to
ea9e3dc
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 11, 2024 15:41
e8b6f11
to
063521c
Compare
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 11, 2024 18:06
063521c
to
69c99e0
Compare
nuwan-samarasinghe
previously approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nice work
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 12, 2024 10:26
69c99e0
to
bbcee2f
Compare
Instead of having login_required and check_internal_user added above each and every route, we can have a central @app.before_request decorator to add the decorators to every route, except those that require public access - static, healthcheck, login and index.
wjrm500
force-pushed
the
FS-4805_FAB-authentication
branch
from
December 12, 2024 10:28
bbcee2f
to
436d9ed
Compare
Quality Gate passedIssues Measures |
samuelhwilliams
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Add authentication for FAB
Description
/
) get redirected to dashboard (previously index) if authenticated, or login if notlogin_required
decorator from our fsd-utils library, which simply checks whether users have authenticated successfullycheck_internal_user
decorator, now also part of the fsd-utils library having recently been ported there from Post-Award Data Store. This decorator checks users have an email domain of either communities.gov.uk or test.communities.gov.uk, which prevents guest users on our Entra ID tenant (i.e., local authority users) from accessingTesting instructions
General pre-requisites
FS-4805_FAB-authentication
is deployed todev
environment for this appFS-4805_FAB-authentication
is deployed todev
environment for AuthenticatorTest 1 - Unauthenticated user
1.0
1.1
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk/dashboard
https://authenticator.dev.access-funding.test.levellingup.gov.uk/service/sso/signed-out/no_token?return_app=fund-application-builder&return_path=%2Fdashboard
and see a page saying "You are not logged in" with a "Sign in" buttonTest 2- Authenticate as an internal user
2.0
2.1
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk/login
and see a page with a button "Sign in using Microsoft"2.2
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk/dashboard
. You will see the normal FAB home page2.3
https://forms.dev.access-funding.test.levellingup.gov.uk
(e.g.,https://forms.dev.access-funding.test.levellingup.gov.uk/apply-for-funding-to-save-an-asset-in-your-community/applicant-information
), where you will be able to preview the form (e.g., you will see a page titled "Applicant information" with a "Continue" button)Test 3 - Authenticate as an external user
Test-specific pre-requisites
3.0
3.1
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk/login
and see a page with a button "Sign in using Microsoft"3.2
https://fund-application-builder.dev.access-funding.test.levellingup.gov.uk/dashboard
. Instead of seeing the normal home page, you will see a page titled "You do not have permission to access this page"