FS-4917 - Remove unused tasks and move test data seeding into tests d…

…irectory

These tasks were developer tools for seeding and manipulating the local database, as well as to manually generate export files. None of this stuff was linked to the frontend. Seeding the local database for unit tests is still required, and so this has been moved to a new place.

tests/conftest.py

@@ -6,8 +6,8 @@
 
 from app.create_app import create_app
 from config import Config
-from tasks.test_data import init_unit_test_data
-from tasks.test_data import insert_test_data
+from tests.seed_test_data import init_unit_test_data
+from tests.seed_test_data import insert_test_data
 
 pytest_plugins = ["fsd_test_utils.fixtures.db_fixtures"]
 

tasks/test_data.py → tests/seed_test_data.py

@@ -95,7 +95,7 @@ def init_salmon_fishing_fund():
             "en": "A £10m fund to improve access to salmon fishing facilities across the devolved nations."
         },
         welsh_available=False,
-        short_name=f"SFF{randint(0,999)}",
+        short_name=f"SFF{randint(0,999)}",  # NOSONAR
         owner_organisation_id=o.organisation_id,
         funding_type=FundingType.COMPETITIVE,
         ggis_scheme_reference_number="G1-SCH-0000092414",
@@ -377,7 +377,7 @@ def init_unit_test_data() -> dict:
         title_json={"en": "funding to improve testing"},
         description_json={"en": "A £10m fund to improve testing across the devolved nations."},
         welsh_available=False,
-        short_name=f"UTF{randint(0,999)}",
+        short_name=f"UTF{randint(0,999)}",  # NOSONAR
         owner_organisation_id=o.organisation_id,
         funding_type=FundingType.COMPETITIVE,
         ggis_scheme_reference_number="G3-SCH-0000092414",
@@ -388,7 +388,7 @@ def init_unit_test_data() -> dict:
         fund_id=f.fund_id,
         audit_info={"user": "dummy_user", "timestamp": datetime.now().isoformat(), "action": "create"},
         title_json={"en": "round the first"},
-        short_name=f"UTR{randint(0,999)}",
+        short_name=f"UTR{randint(0,999)}",  # NOSONAR
         opens=datetime.now(),
         deadline=datetime.now(),
         assessment_start=datetime.now(),
@@ -415,20 +415,6 @@ def init_unit_test_data() -> dict:
         eligibility_config={"has_eligibility": False},
         eoi_decision_schema={"en": {"valid": True}, "cy": {"valid": False}},
     )
-    # r2: Round = Round(
-    #     round_id=uuid4(),
-    #     fund_id=f.fund_id,
-    #     audit_info={"user": "dummy_user", "timestamp": datetime.now().isoformat(), "action": "create"},
-    #     title_json={"en": "round the second"},
-    #     short_name=f"UTR{randint(0,999)}",
-    #     opens=datetime.now(),
-    #     deadline=datetime.now(),
-    #     assessment_start=datetime.now(),
-    #     reminder_date=datetime.now(),
-    #     assessment_deadline=datetime.now(),
-    #     prospectus_link="http://www.google.com",
-    #     privacy_notice_link="http://www.google.com",
-    # )
 
     s1: Section = Section(
         section_id=uuid4(), index=1, round_id=r.round_id, name_in_apply_json={"en": "Organisation Information"}

tests/test_db.py

@@ -24,8 +24,8 @@
 from app.db.queries.fund import get_fund_by_id
 from app.db.queries.round import add_round
 from app.db.queries.round import get_round_by_id
-from tasks.test_data import BASIC_FUND_INFO
-from tasks.test_data import BASIC_ROUND_INFO
+from tests.seed_test_data import BASIC_FUND_INFO
+from tests.seed_test_data import BASIC_ROUND_INFO
 
 
 def test_add_organisation(flask_test_client, _db, clear_test_data):

tests/test_integration.py

@@ -24,8 +24,8 @@
 from app.import_config.load_form_json import load_form_jsons
 from app.shared.data_classes import Condition
 from app.shared.data_classes import ConditionValue
-from tasks.test_data import BASIC_FUND_INFO
-from tasks.test_data import BASIC_ROUND_INFO
+from tests.seed_test_data import BASIC_FUND_INFO
+from tests.seed_test_data import BASIC_ROUND_INFO
 
 
 def test_build_form_json_no_conditions(seed_dynamic_data):