feat: dont create actionnetwork rows in test_sources as they cant be deleted #170
+226
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feat/dont-create-test-action-network-rows - meep-database PR #170
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-backend PR #170
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-backend PR #170
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-frontend PR #170
Render
Destroyed
commonknowledge-bot
deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-worker PR #170
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-frontend PR #170
Render
Destroyed
joaquimds
force-pushed
the
feat/dont-create-test-action-network-rows
branch
from
702504a to
3b7c3ff
Compare
commonknowledge-bot
temporarily deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-worker PR #170
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/dont-create-test-action-network-rows - meep-intelligence-hub-backend PR #170
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running the tests added records to Action Network. This was causing the Action Network group to have 1000s of records, which made the tests very slow.
This PR makes the Action Network tests use existing records.
This PR also fixes a couple of bugs: