forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex geocoding config [MAP-706] [MAP-708] [MAP-707] [MAP-458] #166
Open
janbaykara
wants to merge
66
commits into
main
Choose a base branch
from
feature/map-668-hnh-ward-csv-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feature/map-668-hnh-ward-csv-issues - meep-database PR #166
December 17, 2024 12:32 — with
Render
Active
janbaykara
changed the title
Feature/map 668 hnh ward csv issues
Complex geocoding config
Dec 17, 2024
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: hub/management/commands/import_areas.py
Did you find this useful? React with a 👍 or 👎 |
commonknowledge-bot
temporarily deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-backend PR #166
December 17, 2024 12:33 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-backend PR #166
December 17, 2024 12:33 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-frontend PR #166
December 17, 2024 12:33 — with
Render
Destroyed
commonknowledge-bot
deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-worker PR #166
December 17, 2024 12:33 — with
Render
Active
commonknowledge-bot
had a problem deploying
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-worker PR #166
December 19, 2024 17:35 — with
Render
Failure
commonknowledge-bot
had a problem deploying
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-worker PR #166
December 19, 2024 17:52 — with
Render
Failure
commonknowledge-bot
had a problem deploying
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-worker PR #166
December 19, 2024 18:04 — with
Render
Failure
commonknowledge-bot
had a problem deploying
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-worker PR #166
December 19, 2024 22:51 — with
Render
Failure
commonknowledge-bot
temporarily deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-backend PR #166
December 19, 2024 23:06 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-worker PR #166
December 19, 2024 23:06 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-668-hnh-ward-csv-issues - meep-intelligence-hub-frontend PR #166
December 22, 2024 02:15 — with
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new, more capable geocoding option that can involve multiple fields.
geography_config
is a new approach to geocoding. When the field is set (see test cases), it allows three new approaches to geocoding:geography_config
is set, geocoding cannot be set differently by the user in the UI. So there are some JSX changes for that.