-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the description of the record field annotation for link validation #631
Conversation
Uh... Let me clarify the specification. Which is correct?
If the latter is correct, I will fix this request to mention the |
Identity controls which resolution rule to use. But also, Another way of specifying that a field is an identifier is with It is inherited from JSON-LD where I can't recall exactly why I made a separate |
Ok, I refreshed my memory. There are fields that are identifiers. They identify the object they are found on. However there are also fields whose values have the "identity" property. These are expanded like identifiers, but they don't identify the object they are found on, they just exist as a standalone value. The main example of this are the symbols of an enumeration. |
Thanks @tetron ; do we need to change/clarify the text still? |
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 83.43% 83.43%
=======================================
Files 20 20
Lines 4039 4039
Branches 1096 1096
=======================================
Hits 3370 3370
Misses 426 426
Partials 243 243 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The spec says:
However, it is not correct because
identity: false
(or unspecifiedidentity
) is also needed as described in the section ofJsonldPredicate#_type
.This request fixes it by clarifying the value of
identity
in addition to the field_type
.